Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: sort markdown refs in errors #23972

Closed
wants to merge 1 commit into from
Closed

doc: sort markdown refs in errors #23972

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Oct 30, 2018 •
edited
Loading

Checklist

@nodejs-github-bot
Copy link
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1420/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Oct 30, 2018
@sam-github
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/18231/

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

Linter and linuxone CI jobs are green, so this suffices for doc changes.

@sam-github sam-github added fast-track PRs that do not need to wait for 48 hours to land. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Oct 30, 2018
@sam-github sam-github added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 30, 2018
@sam-github
Copy link
Contributor Author

Landed in 669c611

@sam-github sam-github closed this Oct 30, 2018
@sam-github sam-github deleted the sort-http-refs branch October 30, 2018 21:37
sam-github added a commit that referenced this pull request Oct 30, 2018
@sam-github
doc: sort markdown refs in errors
669c611 
PR-URL: #23972
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 1, 2018
@sam-github @targos
doc: sort markdown refs in errors
ee6b039 
PR-URL: #23972
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 1, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
@MylesBorins
Copy link
Contributor

This does not land cleanly on 8.x or 10.x

Please feel free to open PRs to sort those specific lines

@sam-github sam-github mentioned this pull request Nov 27, 2018
Closed
4 tasks
sam-github added a commit to sam-github/node that referenced this pull request Nov 29, 2018
@sam-github
doc: sort markdown refs in errors
4cc8ec2 
Backport-PR-URL: nodejs#24678
PR-URL: nodejs#23972
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sam-github @nodejs-github-bot @vsemozhetbyt @MylesBorins @lpinca