Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixed error message in test-buffer-read module #23957

Closed
wants to merge 3 commits into from
Closed

test: fixed error message in test-buffer-read module #23957

wants to merge 3 commits into from

Conversation

arvind3157
Copy link
Contributor

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ x] commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 29, 2018
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if CI passes.

@Trott
Copy link
Member

Trott commented Oct 29, 2018

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 29, 2018
RangeError);
assert.throws(
() => Buffer.allocUnsafe(8).readFloatBE(0xffffffff),
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following object can be stored in a variable and can be passed as a second argument:

{
   name: 'RangeError [ERR_OUT_OF_RANGE]'
}

Same applies to this object on line 89 and 96:

{
      name: 'RangeError [ERR_BUFFER_OUT_OF_BOUNDS]',
      message: 'Attempt to write outside buffer bounds'
 }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trivikr I will do the changes and commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see I missed the point. I had to parametrize the object, not the value. Pushing the changes in next commit.

@Trott
Copy link
Member

Trott commented Oct 31, 2018

@arvind3157
Copy link
Contributor Author

Most of the tests passed. It failed for windows. Any known issue or something I should worry about why this is failing?

@Trott
Copy link
Member

Trott commented Oct 31, 2018

It failed for windows. Any known issue or something I should worry about why this is failing?

Certainly unrelated. I've opened #24005 about it.

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18266/

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 31, 2018
PR-URL: nodejs#23957
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 31, 2018

Landed in e35f671.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants