Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor out some warnings from FillStatsArray and node_file.h #23793

Merged
merged 3 commits into from
Oct 24, 2018
Merged

src: refactor out some warnings from FillStatsArray and node_file.h #23793

merged 3 commits into from
Oct 24, 2018

Commits on Oct 24, 2018

  1. src: refactor FillStatsArray 

    PR-URL: nodejs#23793
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @refack
    refack committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    fb897fb View commit details
    Browse the repository at this point in the history

  2. src: fix resource leak in node::fs::FileHandle 

    PR-URL: nodejs#23793
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @refack
    refack committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    5ab807d View commit details
    Browse the repository at this point in the history

  3. src: clean clang-tidy errors in node_file.h 

    * explicitly delete move overloads
* default initialize all members
* explicitly discard unused return values
* const some possibles

PR-URL: nodejs#23793
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @refack
    refack committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    205b667 View commit details
    Browse the repository at this point in the history