Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix coverage generation #23769

Closed
wants to merge 1 commit into from
Closed

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Oct 19, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

build: fix coverage generation

Changes in command line options for nyc resulted in the
coverage target no longer working.

Pin the major version of nyc and update the options to
get it working again.

Fixes: #23690

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 19, 2018
@mhdawson
Copy link
Member Author

@mhdawson mhdawson changed the title Fixcov build: fix coverage generation Oct 20, 2018
@mhdawson mhdawson self-assigned this Oct 20, 2018
@mhdawson mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 20, 2018
@mhdawson
Copy link
Member Author

Coverage CI was good and I'd like to fast track this to get our coverage builds green again

@mhdawson
Copy link
Member Author

@refack
Copy link
Contributor

refack commented Oct 20, 2018

/CC @nodejs/build-files

Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we can consider installing nyc in a directory under tools with a package.json to pin the version? (like what we do with lint-md-build)

@mhdawson
Copy link
Member Author

Failure was known issue seen before, resumed build here: https://ci.nodejs.org/job/node-test-pull-request/18045/

Changes in command line options for nyc resulted in the
coverage target no longer working.

Pin the major version of nyc and update the options to
get it working again.

PR-URL: nodejs#23769
Fixes: nodejs#23690
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@mhdawson
Copy link
Member Author

Landed as 9464e43

mhdawson added a commit that referenced this pull request Oct 22, 2018
Changes in command line options for nyc resulted in the
coverage target no longer working.

Pin the major version of nyc and update the options to
get it working again.

PR-URL: #23769
Fixes: #23690
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@mhdawson
Copy link
Member Author

Arg, noticed I jumped the gun and the resume failed as well.

Build of master to see if fails there consistently as well: https://ci.nodejs.org/job/node-test-commit-linux/22568/

@mhdawson
Copy link
Member Author

mhdawson commented Oct 22, 2018

This is the issue for the faliure -> #16601 here: test-fs-readfile-tostring-fail

If the run in master fails, I'll look at creating a PR which marks the test as flaky.

@mhdawson
Copy link
Member Author

Build in master was ok. So I'm assuming that if I had resumed again, or rebased and run a new CI it would have passed. Sorry for having jumped the gun, but I think I'm ok to close this now.

@mhdawson mhdawson closed this Oct 22, 2018
jasnell pushed a commit that referenced this pull request Oct 22, 2018
Changes in command line options for nyc resulted in the
coverage target no longer working.

Pin the major version of nyc and update the options to
get it working again.

PR-URL: #23769
Fixes: #23690
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@MylesBorins
Copy link
Contributor

This lands cleanly on v10.x but requires a backport for 8.x

MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
Changes in command line options for nyc resulted in the
coverage target no longer working.

Pin the major version of nyc and update the options to
get it working again.

PR-URL: #23769
Fixes: #23690
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Changes in command line options for nyc resulted in the
coverage target no longer working.

Pin the major version of nyc and update the options to
get it working again.

PR-URL: #23769
Fixes: #23690
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
Changes in command line options for nyc resulted in the
coverage target no longer working.

Pin the major version of nyc and update the options to
get it working again.

PR-URL: #23769
Fixes: #23690
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
@mhdawson mhdawson deleted the fixcov branch September 30, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure in code coverage job
7 participants