doc: document that addMembership must be called once in a cluster #23746
Conversation
nodejs-github-bot
added
dgram
doc/api/dgram.md
Outdated
| @@ -95,6 +95,24 @@ Tells the kernel to join a multicast group at the given `multicastAddress` and | |||
| one interface and will add membership to it. To add membership to every | |||
| available interface, call `addMembership` multiple times, once per interface. | |||
|
|
|||
| When sharing a UDP socket across multiple `cluster` workers, the | |||
| `socket.addMembership()` function must only be called *only once* or an | |||
There was a problem hiding this comment.
There is one too many occurrences of the word only.
FWIW, I'd avoid the italics here too.
There was a problem hiding this comment.
Feel free to make any edits you'd like
There was a problem hiding this comment.
There is the new github feature to make suggestions that add a commit by accepting the suggestion :-)
There was a problem hiding this comment.
If I am not mistaken, any Collaborator can assign themselves to a PR and accept an own proposed change. This can alleviate nit addressing for the PR author, but also can be felt like a bit arbitrarily thing. But if a PR author declares concent, this seems OK.
doc/api/dgram.md
Outdated
| ```js | ||
| const cluster = require('cluster'); | ||
| const dgram = require('dgram'); | ||
| if (cluster.isMaster) { |
There was a problem hiding this comment.
Linter is failing because of indentation issues on this line and the next two lines.
jasnell
added
the
author ready
|
Experiment: I am trying to assign myself to the PR and accept my own nit change proposal (which === pushing to the PR branch?). |
Co-Authored-By: jasnell <jasnell@gmail.com>
Co-Authored-By: jasnell <jasnell@gmail.com>
|
Oh! Sorry @vsemozhetbyt ... I accepted the changes then saw you note about trying an experiment... hopefully I didn't mess it up |
|
Fails: I can see "Apply suggestion" button, But I cannot apply the change: Screenshots:
|
|
Not sure if this was a race condition, we can try it again later in some other PR) |
|
Please 👍 to fast track |
|
Landed in 30d42f6 |
Fixes: #12572
Refs: #16240
Checklist