Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixed strictEqual arguments order #23576

Closed
wants to merge 1 commit into from
Closed

test: fixed strictEqual arguments order #23576

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Member

Fixes usage of strictEqual arguments order in test/parallel/test-process-wrap.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

PS: Part of Node+JS Interactive 2018 Code & Learn

@ruyadorno
test: fixed strictEqual arguments order
60626dc 
Fixes usage of strictEqual arguments order in
test/parallel/test-process-wrap.js

Part of Node+JS Interactive 2018 Code & Learn
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@ruyadorno @BridgeAR
test: fixed strictEqual arguments order
6cb499e 
Fixes usage of strictEqual arguments order in
test/parallel/test-process-wrap.js

Part of Node+JS Interactive 2018 Code & Learn

PR-URL: nodejs#23576
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@ruyadorno @BridgeAR
test: fixed strictEqual arguments order
bc89f9b 
Fixes usage of strictEqual arguments order in
test/parallel/test-process-wrap.js

Part of Node+JS Interactive 2018 Code & Learn

PR-URL: nodejs#23576
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@BridgeAR
Copy link
Member

Landed in bc89f9b 🎉

@ruyadorno congratulations on your commit to Node.js!

@BridgeAR BridgeAR closed this Oct 15, 2018
@ruyadorno ruyadorno deleted the test-fix-strict-equal-assertion branch October 15, 2018 16:42
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@ruyadorno @jasnell
test: fixed strictEqual arguments order
152e7a5 
Fixes usage of strictEqual arguments order in
test/parallel/test-process-wrap.js

Part of Node+JS Interactive 2018 Code & Learn

PR-URL: #23576
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@ruyadorno @addaleax
test: fixed strictEqual arguments order
0834198 
Fixes usage of strictEqual arguments order in
test/parallel/test-process-wrap.js

Part of Node+JS Interactive 2018 Code & Learn

PR-URL: #23576
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@ruyadorno @MylesBorins
test: fixed strictEqual arguments order
b68ee22 
Fixes usage of strictEqual arguments order in
test/parallel/test-process-wrap.js

Part of Node+JS Interactive 2018 Code & Learn

PR-URL: #23576
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@ruyadorno @rvagg
test: fixed strictEqual arguments order
6a38a55 
Fixes usage of strictEqual arguments order in
test/parallel/test-process-wrap.js

Part of Node+JS Interactive 2018 Code & Learn

PR-URL: #23576
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@ruyadorno @MylesBorins
test: fixed strictEqual arguments order
7fed93d 
Fixes usage of strictEqual arguments order in
test/parallel/test-process-wrap.js

Part of Node+JS Interactive 2018 Code & Learn

PR-URL: #23576
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ruyadorno @BridgeAR @jasnell @thefourtheye @addaleax @cjihrig @gireeshpunathil @trivikr @nodejs-github-bot