Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove ABI guide #23303

Closed
wants to merge 1 commit into from
Closed

doc: remove ABI guide #23303

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Move it to the nodejs.org repo.

Checklist

doc: remove ABI guide
b52e049 
Move it to the nodejs.org repo.
@nodejs-github-bot
Copy link
Collaborator

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1147/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 7, 2018
@gabrielschulhof
Copy link
Contributor Author

nodejs/nodejs.org#1828

@gabrielschulhof gabrielschulhof mentioned this pull request Oct 7, 2018
Closed
3 tasks
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the node-api Issues and PRs related to the Node-API. label Oct 7, 2018
@gabrielschulhof
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17672/

@gabrielschulhof
Copy link
Contributor Author

Landed in fd6a7d4.

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Oct 7, 2018
doc: remove ABI guide
fd6a7d4 
Move it to the nodejs.org repo.

PR-URL: nodejs#23303
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@gabrielschulhof gabrielschulhof deleted the remove-abi-guide branch October 7, 2018 16:05
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 7, 2018
@Trott
Copy link
Member

Trott commented Oct 8, 2018

Theoretically, this shouldn't have landed quite yet because the second 👍 was not from a Collaborator on the core repo. But that's OK, I'm going to add a post-facto 👍 right now! 😆

@Trott
Copy link
Member

Trott commented Oct 8, 2018

Theoretically, this shouldn't have landed quite yet because the second 👍 was not from a Collaborator on the core repo. But that's OK, I'm going to add a post-facto 👍 right now! 😆

(This would be a possible argument for either eliminating wait times altogether or else automating more. I know there's been talk about having ncu check fast-track approvals but I'm not sure what obstacles might exist. OK, I'll stop rambling...)

@gabrielschulhof
Copy link
Contributor Author

@Trott Thanks! Maybe we should edit into the request to 👍 instead of reacting to it with an emoji:

Add your 👍 here to fast-track:<👍s go here>

targos pushed a commit that referenced this pull request Oct 10, 2018
@targos
doc: remove ABI guide
f1cb8ab 
Move it to the nodejs.org repo.

PR-URL: #23303
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@targos targos mentioned this pull request Oct 10, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request Oct 11, 2018
Closed
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@jasnell
doc: remove ABI guide
7401362 
Move it to the nodejs.org repo.

PR-URL: #23303
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gabrielschulhof @nodejs-github-bot @vsemozhetbyt @Trott @targos