Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use unique_ptr for obj in SetWeak lambda #23117

Closed
wants to merge 1 commit into from
Closed

src: use unique_ptr for obj in SetWeak lambda #23117

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 27, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1038/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 27, 2018
@danbev
Copy link
Contributor Author

danbev commented Sep 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17467/

addaleax
addaleax approved these changes Sep 27, 2018
View reviewed changes
src/base_object-inl.h Show resolved Hide resolved
@addaleax
Copy link
Member

Rebuild CI: https://ci.nodejs.org/job/node-test-pull-request/17496/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 28, 2018
@addaleax
Copy link
Member

Again: https://ci.nodejs.org/job/node-test-pull-request/17528/

@danbev
Copy link
Contributor Author

danbev commented Oct 1, 2018 •
edited
Loading

Another CI: https://ci.nodejs.org/job/node-test-pull-request/17543/ ✔️

@danbev
Copy link
Contributor Author

danbev commented Oct 1, 2018

Landed in 7ac109d.

@danbev danbev closed this Oct 1, 2018
@danbev danbev deleted the base_object_unique_ptr branch October 1, 2018 06:17
danbev added a commit that referenced this pull request Oct 1, 2018
@danbev
src: use unique_ptr for obj in SetWeak lambda
7ac109d 
PR-URL: #23117
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 1, 2018
@danbev @targos
src: use unique_ptr for obj in SetWeak lambda
549433f 
PR-URL: #23117
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
targos pushed a commit that referenced this pull request Oct 3, 2018
@danbev @targos
src: use unique_ptr for obj in SetWeak lambda
ce7fad5 
PR-URL: #23117
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danbev @nodejs-github-bot @addaleax @jasnell