test: add tests to check error in dns.lookupService. #22908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests to check error in dns.lookupService to increase coverage.
addaleax
approved these changes
Sep 17, 2018
cjihrig
approved these changes
Sep 17, 2018
starkwang
approved these changes
Sep 18, 2018
thefourtheye
approved these changes
Sep 18, 2018
| const dns = require('dns'); | ||
|
|
||
| // Stub `getnameinfo` to *always* error. | ||
| cares.getnameinfo = () => internalBinding('uv').UV_ENOENT; |
There was a problem hiding this comment.
Nit: uv could be assigned to a variable.
lpinca
approved these changes
Sep 18, 2018
jasnell
approved these changes
Sep 19, 2018
|
Landed in 0623aab. |
danbev
pushed a commit
that referenced
this pull request
Sep 20, 2018
Added tests to check error in dns.lookupService to increase coverage. PR-URL: #22908 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2018
Added tests to check error in dns.lookupService to increase coverage. PR-URL: #22908 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to check error in dns.lookupService to
increase coverage.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes