Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix Array.prototype.forEach on v8 6.8 #22899

Closed
wants to merge 1 commit into from

Conversation

ripsawridge
Copy link

Refs: #22859

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Sep 17, 2018
@Trott
Copy link
Member

Trott commented Sep 18, 2018

@nodejs/v8-update

@BridgeAR
Copy link
Member

The title and description seems different than what we normally do. An example of such a commit is ab15016

Right now I am not sure what commit this will include from V8.

@targos
Copy link
Member

targos commented Sep 19, 2018

The pull request should target the master branch or, if the slowdown does not affect V8 6.9, v10.x-staging.

@hashseed
Copy link
Member

@ripsawridge is currently on vacation.

@targos
Copy link
Member

targos commented Sep 21, 2018

We are about to merge V8 7.0 into master so v10.x-staging seems to be the best target now.

@addaleax addaleax changed the base branch from v11.x-staging to v10.x-staging September 22, 2018 10:07
@addaleax addaleax force-pushed the patchy branch 2 times, most recently from 2caf1c0 to d885262 Compare September 22, 2018 10:16
This applies a variant of v8/v8@e1163c14f7e4fef2c549 to V8 6.8.

Original commit message:

    [Builtins] Array.prototype.forEach perf regression on dictionaries

    An unnecessary call to ToString() on the array index caused trips to
    the runtime. The fix also includes performance micro-benchmarks so
    we'll have a harder time regressing this case in future.

    TBR=tebbi@chromium.org

    Bug: v8:8112
    Change-Id: I781e8b1bbe2eb56db961cf33b0dca8523868b83d
    Reviewed-on: https://chromium-review.googlesource.com/1213207
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Reviewed-by: Michael Stanton <mvstanton@chromium.org>
    Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#55733}

Refs: v8/v8@e1163c1
Fixes: nodejs#22859
@addaleax
Copy link
Member

I’ve rebased against v10.x-staging, and update the commit message to point to v8/v8@e1163c1 (this is not a clean cherry-pick, though).

CI: https://ci.nodejs.org/job/node-test-pull-request/17368/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1709/

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamp

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. v10.x labels Sep 22, 2018
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2018
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this needs a rebase again

@targos
Copy link
Member

targos commented Sep 25, 2018

The embedder string can be fixed while landing

@jasnell
Copy link
Member

jasnell commented Sep 25, 2018

Needs a quick rebase

targos pushed a commit that referenced this pull request Sep 25, 2018
This applies a variant of v8/v8@e1163c14f7e4fef2c549 to V8 6.8.

Original commit message:

    [Builtins] Array.prototype.forEach perf regression on dictionaries

    An unnecessary call to ToString() on the array index caused trips to
    the runtime. The fix also includes performance micro-benchmarks so
    we'll have a harder time regressing this case in future.

    TBR=tebbi@chromium.org

    Bug: v8:8112
    Change-Id: I781e8b1bbe2eb56db961cf33b0dca8523868b83d
    Reviewed-on: https://chromium-review.googlesource.com/1213207
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Reviewed-by: Michael Stanton <mvstanton@chromium.org>
    Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55733}

Refs: v8/v8@e1163c1
Fixes: #22859
PR-URL: #22899
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member

targos commented Sep 25, 2018

Landed in 5d70652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants