tools: .eslintrc.js messages "default" typo style #22868
Conversation
* all methods and syntax keywords between backticks * written numbers
* moving /* eslint-disable max-len */
|
It seems a common style is already shared by all messages, what is the advantage of adding backticks? |
|
Actually, a single error message has it: https://github.com/nodejs/node/blob/master/.eslintrc.js#L163 so I thought that all should have it, or none, and if any new message is added it will probably follow the pattern of the others, I'm aware that it's a small change and it can not be that relevant(no problem in closing the pr). |
.eslintrc.js
Outdated
| }, | ||
| { | ||
| selector: 'ThrowStatement > CallExpression[callee.name=/Error$/]', | ||
| message: 'Use new keyword when throwing an Error.', | ||
| message: 'Use `new` keyword when throwing an Error.', |
There was a problem hiding this comment.
Nit: Add backticks around Error as well?
There was a problem hiding this comment.
Added, it looks better in the sentence now
* Error object backtick
|
Landed in 4e09fc3 🎉 |
"Default" typo pattern for .eslintrc.js messages * all methods and syntax keywords between backticks * written numbers * moving /* eslint-disable max-len */ * Error object backtick PR-URL: #22868 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
"Default" typo pattern for .eslintrc.js messages * all methods and syntax keywords between backticks * written numbers * moving /* eslint-disable max-len */ * Error object backtick PR-URL: #22868 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
make all messages in .eslintrc.js follow a in common style
Checklist