src: move process.binding('tcp_wrap') to internal #22432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
33 tasks
danbev
added
the
semver-major
addaleax
approved these changes
Aug 21, 2018
jasnell
approved these changes
Aug 21, 2018
BridgeAR
reviewed
Aug 21, 2018
| @@ -19,6 +19,7 @@ | |||
| // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | |||
| // USE OR OTHER DEALINGS IN THE SOFTWARE. | |||
|
|
|||
| // Flags: --expose-internals | |||
There was a problem hiding this comment.
Why is this now needed? The same in the part below.
There was a problem hiding this comment.
The reason for this is that there is a call of the function common.hasMultiLocalhost() below this line which now uses require('internal/test/binding').
trivikr
approved these changes
Aug 22, 2018
This commit makes the tcp_wrap builtin an internal builtin, and
changes usage of the builtin from using process.binding('tcp_wrap')
to use internalBinding instead.
Refs: nodejs#22160
danbev
force-pushed
the
tcp_wrap_move_internalBinding
branch
from
6a28092 to
a2f97bc
Compare
|
Landed in 57d98bc. |
danbev
added a commit
that referenced
this pull request
Aug 24, 2018
This commit makes the tcp_wrap builtin an internal builtin, and
changes usage of the builtin from using process.binding('tcp_wrap')
to use internalBinding instead.
Refs: #22160
PR-URL: #22432
Refs: #22160
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the tcp_wrap builtin an internal builtin, and
changes usage of the builtin from using process.binding('tcp_wrap')
to use internalBinding instead.
Refs: #22160
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes