-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: implement query callbacks for vm #22390
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5878,6 +5878,26 @@ enum class PropertyHandlerFlags { | |
}; | ||
|
||
struct NamedPropertyHandlerConfiguration { | ||
NamedPropertyHandlerConfiguration( | ||
GenericNamedPropertyGetterCallback getter, | ||
GenericNamedPropertySetterCallback setter, | ||
GenericNamedPropertyQueryCallback query, | ||
GenericNamedPropertyDeleterCallback deleter, | ||
GenericNamedPropertyEnumeratorCallback enumerator, | ||
GenericNamedPropertyDefinerCallback definer, | ||
GenericNamedPropertyDescriptorCallback descriptor, | ||
Local<Value> data = Local<Value>(), | ||
PropertyHandlerFlags flags = PropertyHandlerFlags::kNone) | ||
: getter(getter), | ||
setter(setter), | ||
query(query), | ||
deleter(deleter), | ||
enumerator(enumerator), | ||
definer(definer), | ||
descriptor(descriptor), | ||
data(data), | ||
flags(flags) {} | ||
|
||
NamedPropertyHandlerConfiguration( | ||
/** Note: getter is required */ | ||
GenericNamedPropertyGetterCallback getter = 0, | ||
|
@@ -5929,6 +5949,25 @@ struct NamedPropertyHandlerConfiguration { | |
|
||
|
||
struct IndexedPropertyHandlerConfiguration { | ||
IndexedPropertyHandlerConfiguration( | ||
IndexedPropertyGetterCallback getter, | ||
IndexedPropertySetterCallback setter, IndexedPropertyQueryCallback query, | ||
IndexedPropertyDeleterCallback deleter, | ||
IndexedPropertyEnumeratorCallback enumerator, | ||
IndexedPropertyDefinerCallback definer, | ||
IndexedPropertyDescriptorCallback descriptor, | ||
Local<Value> data = Local<Value>(), | ||
PropertyHandlerFlags flags = PropertyHandlerFlags::kNone) | ||
: getter(getter), | ||
setter(setter), | ||
query(query), | ||
deleter(deleter), | ||
enumerator(enumerator), | ||
definer(definer), | ||
descriptor(descriptor), | ||
data(data), | ||
flags(flags) {} | ||
|
||
IndexedPropertyHandlerConfiguration( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @TimothyGu I noticed in the linked to issues in the opening summary that V8 work was needed. A patch for V8 was merged but then reverted for perf reasons. Was the perf issue eventually resolved and the appropriate V8 changed landed or is this PR working around V8? |
||
/** Note: getter is required */ | ||
IndexedPropertyGetterCallback getter = 0, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimothyGu As someone not super familiar with the internals of this (me) can you explain a bit about how this is fixing the linked to issues.