-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade npm to 6.4.0 #22342
deps: upgrade npm to 6.4.0 #22342
Conversation
Yes, I'm aware of the policy, seeing as I was part of the discussion for it. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
This PR needs a rebase against master to avoid the git failure in the CI. |
@joyeecheung would it not be sufficient to rebase on the CI task? |
I've rebased it 👍 |
Moving this to #22591, since 6.4.1 came out in the meantime 😅 |
Doesn't that mean we have to wait another 2 weeks to get npm@6.4.x integrated? |
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesWhere this should land
Notable Changes
This release includes two versions of npm, including the current
latest
release,npm@6.4.0
.f861c2b57
node-gyp@3.8.0
: This means our entire npm dep tree now uses the latestnode-gyp
, and we've updated and flattenedrequest
as well.npm audit
on npm itself comes up clean now! (@rvagg)6e9f04b0b
npm/cli#8 Search for authentication token defined by environment variables by preventing the translation layer from env variable to npm option from breaking:_authToken
. (@mkhl)84bfd23e7
npm/cli#35 Stop filtering out non-IPv4 addresses fromlocal-addrs
, making npm actually use IPv6 addresses when it must. (@valentin2105)d81146181
npm/cli#32 Don't check for updates to npm when we are updating npm itself. (@olore)Another reminder that we've moved our issue tracking! You can read more about our move away from GitHub for issue tracking on our blog
Changelogs