Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename some disturbing allegories #22307

Closed
wants to merge 1 commit into from
Closed

test: rename some disturbing allegories #22307

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This somehow hit me in #22303, so I thought we could do the same we had done for the child_process doc. I've renamed only some cases where renaming impact was not so big.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 14, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Aug 14, 2018

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💙

@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor Author

Concerning repeated fails: #22308

@refack
Copy link
Contributor

refack commented Aug 14, 2018

Rest of fails are git related - nodejs/reliability#12 (comment)
So IMHO this is ready to land

@refack refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 14, 2018
@refack
Copy link
Contributor

refack commented Aug 14, 2018

@vsemozhetbyt I would rename the commit to something more generic, like
test: rename allegories, just to reduce curiosity.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 14, 2018
@vsemozhetbyt
Copy link
Contributor Author

Landed in 682f9b4 with more generic commit name.
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the rename-disturbing branch August 14, 2018 14:56
vsemozhetbyt added a commit that referenced this pull request Aug 14, 2018
PR-URL: #22307
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 15, 2018
PR-URL: #22307
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants