Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: show hidden item count #22289

Closed
wants to merge 2 commits into from
Closed

buffer: show hidden item count #22289

wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

This adds the number of hidden items in case INSPECT_MAX_BYTES is
exceeded.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
buffer: show hidden item count
408c95b 
This adds the number of hidden items in case INSPECT_MAX_BYTES is
exceeded.
@BridgeAR BridgeAR added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 12, 2018
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/540/pipeline

@nodejs-github-bot nodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label Aug 12, 2018
@trivikr
Copy link
Member

trivikr commented Aug 12, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16399/

addaleax
addaleax approved these changes Aug 12, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can be specific here and say 'byte(s)' instead of 'item(s)', if you like

@BridgeAR
Copy link
Member Author

@addaleax I thought about that as well but my intention was to keep it in line with all other util.inspect extra items. But in this case you are likely right that it looks nicer.

@BridgeAR
Copy link
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/16402/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 13, 2018
@BridgeAR BridgeAR requested a review from a team August 13, 2018 00:25
@BridgeAR
Copy link
Member Author

Build is fine after rerunning freebsd
https://ci.nodejs.org/job/node-test-commit-freebsd/19694/
https://ci.nodejs.org/job/node-test-commit/20528/

BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 15, 2018
@BridgeAR
buffer: show hidden item count
755520c 
This adds the number of hidden items in case INSPECT_MAX_BYTES is
exceeded.

PR-URL: nodejs#22289
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR
Copy link
Member Author

Landed in 755520c 🎉

@BridgeAR BridgeAR closed this Aug 15, 2018
@BridgeAR BridgeAR deleted the add-extra-buffer-properties branch January 20, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BridgeAR @nodejs-github-bot @trivikr @jasnell @addaleax @lpinca