fixup: test: remove common.fileExists() #22200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-trace-event-promises.js was added to the codebase between the last CI for nodejs#22151 and it landing. Refs: nodejs#22151
3 tasks
vsemozhetbyt
approved these changes
Aug 8, 2018
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
benjamingr
approved these changes
Aug 8, 2018
maclover7
approved these changes
Aug 8, 2018
trivikr
approved these changes
Aug 8, 2018
4 tasks
MylesBorins
added
the
fast-track
cjihrig
approved these changes
Aug 8, 2018
lpinca
approved these changes
Aug 8, 2018
devsnek
approved these changes
Aug 8, 2018
benjamn
approved these changes
Aug 8, 2018
|
landed in d7e1847 |
MylesBorins
pushed a commit
that referenced
this pull request
Aug 8, 2018
test-trace-event-promises.js was added to the codebase between the last CI for #22151 and it landing. PR-URL: #22200 Refs: #22151 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
|
@richardlau Thanks for fixing my misstep! |
targos
pushed a commit
that referenced
this pull request
Aug 11, 2018
test-trace-event-promises.js was added to the codebase between the last CI for #22151 and it landing. PR-URL: #22200 Refs: #22151 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-trace-event-promises.js was added to the codebase between the last
CI for #22151 and it landing.
Refs: #22151
make -j4 test(UNIX), orvcbuild test(Windows) passes