-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update to mdast-util-to-hast v3.0.2 #22140
Conversation
There is good news. This PR fix two known regressions and one previously unknown regression:
|
There is bad news. This PR introduces one new regression. If a heading has two consecutive optional parameters in square brackets, they are not rendered as links, but some preprocess cleaning is done as if they are links:
Compare these examples before and after this PR: |
And there is good bad news) Comparing the diff helps to find out one issue that is differently exposed before and after this PR.
Compare the doc from the old toolchain: https://nodejs.org/docs/latest-v8.x/api/dns.html#dns_dns_resolvetxt_hostname_callback One of the concerned code fragments: Lines 138 to 141 in 28c70ac
|
I know what's going on. I'll try to see if i can create another patch for mdast-util-to-hast. |
Three pull requests created to solve (most) of the problems noted above:
The 2-dimensional array appears to be a separate problem in that remark, et. al., appears to be doing the right thing. Once the above fixes land, I'll look into fixing that problem too. |
Should this update the corresponding |
@Trott will do... once the above three patches are resolved. But first, there are yaks that need shaving: syntax-tree/mdast#23 (comment) |
Preferred long term fix can be found at: nodejs#22140
Ping @rubys ... what's the status on this one? |
The PRs listed in #22140 (comment) need a follow-up |
@rubys Looks like all upstream yaks have been shaved and this can be rebased, run through CI, and hopefully landed? |
8f1c6ab
to
6118207
Compare
Took the liberty of rebasing. Hope that's OK. Still have to install the upstream dependencies that have been updated and run through CI? |
6118207
to
ade009e
Compare
See syntax-tree/mdast-util-to-hast#21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: nodejs#22140 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ade009e
to
cba2c7a
Compare
See syntax-tree/mdast-util-to-hast#21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: #22140 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
See syntax-tree/mdast-util-to-hast#21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: #22140 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
See syntax-tree/mdast-util-to-hast#21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: #22140 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
See syntax-tree/mdast-util-to-hast#21 Note: I updated all of the tools/doc dependencies, not just this one, and removed the previous workaround that was in place until this change landed. PR-URL: #22140 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
See syntax-tree/mdast-util-to-hast#21
Fixes #22065
Note: I updated all of the tools/doc dependencies, not just this one,
and removed the previous workaround that was in place until this change
landed.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes