crypto: simplify state failure handling #22131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is more intuitive to return true/false instead of undefined/false and also simplifies handling in the JS layer.
nodejs-github-bot
added
c++
|
cc @nodejs/crypto |
|
@nodejs/security-wg |
maclover7
approved these changes
Aug 5, 2018
tniessen
added
the
author ready
lpinca
approved these changes
Aug 5, 2018
|
Landed in 77ac962 |
trivikr
pushed a commit
that referenced
this pull request
Aug 8, 2018
It is more intuitive to return true/false instead of undefined/false and also simplifies handling in the JS layer. PR-URL: #22131 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 11, 2018
It is more intuitive to return true/false instead of undefined/false and also simplifies handling in the JS layer. PR-URL: #22131 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
This was referenced Aug 16, 2018
tniessen
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more intuitive to return
true/falsethanundefined/false. This also simplifies handling in the JS layer and removes two control-flow branches from C++.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes