Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove calls to deprecated v8 functions (NumberValue) #22094

Closed
wants to merge 3 commits into from
Closed

src: remove calls to deprecated v8 functions (NumberValue) #22094

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2eb2c9c
src: remove calls to deprecated v8 functions (NumberValue)
ryzokuken Aug 2, 2018
feb53d1
fixup! src: remove calls to deprecated v8 functions (NumberValue)
ryzokuken Aug 3, 2018
8a5affd
fixup! src: remove calls to deprecated v8 functions (NumberValue)
ryzokuken Aug 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/async_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,15 +410,17 @@ void AsyncWrap::PopAsyncIds(const FunctionCallbackInfo<Value>& args) {
void AsyncWrap::AsyncReset(const FunctionCallbackInfo<Value>& args) {
AsyncWrap* wrap;
ASSIGN_OR_RETURN_UNWRAP(&wrap, args.Holder());
double execution_async_id = args[0]->IsNumber() ? args[0]->NumberValue() : -1;
double execution_async_id =
args[0]->IsNumber() ? args[0].As<Number>()->Value() : -1;
wrap->AsyncReset(execution_async_id);
}


void AsyncWrap::QueueDestroyAsyncId(const FunctionCallbackInfo<Value>& args) {
CHECK(args[0]->IsNumber());
AsyncWrap::EmitDestroy(
Environment::GetCurrent(args), args[0]->NumberValue());
Environment::GetCurrent(args),
args[0]->NumberValue(args.GetIsolate()->GetCurrentContext()).ToChecked());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We skip validation of the argument in JS land when async hooks checks are disabled – so we probably don’t want ToChecked()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, dunno. There's literally a CHECK above, so I thought ToChecked would work here. I mean, it might still crash, sure, but nowhere it didn't crash earlier.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, I missed that – in that case, we don’t need NumberValue() either and can cast via .As<Number>(), right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:P You're right. Updating the PR.

}

void AsyncWrap::AddWrapMethods(Environment* env,
Expand Down