Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: allow to add lines to scatter plots #22074

Closed
wants to merge 2 commits into from
Closed

benchmark: allow to add lines to scatter plots #22074

wants to merge 2 commits into from

Conversation

lundibundi
Copy link
Member

Adds --add-lines option to scatter.R that will add lines between the points of the same category.

It was helpful for me to see a general trend with different options, so I added this.
Also, this is my first time working with R so please be thorough, maybe I've missed something.

Checklist
  • make -j4 test (UNIX) passes
  • documentation is changed or added (I'll change benchmark guide later it this is an acceptable change)
  • commit message follows [commit guidelines]

test-plot
test-plot-lines

/cc @nodejs/benchmarking

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Aug 1, 2018
@BridgeAR BridgeAR requested a review from AndreasMadsen August 1, 2018 23:49
AndreasMadsen
AndreasMadsen approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@AndreasMadsen AndreasMadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I don't see why it needs to be an option.

@lundibundi
Copy link
Member Author

Making it non-optional is okay with me too, as it's hard to understand the plot based on dots-colors alone. I just didn't want to disrupt those who already use it too much.
Should we +1 on this to make a simple vote for non-optional(+1) vs optional(-1)?

I'll add/change the doc example once this is decided then.

@AndreasMadsen
Copy link
Member

@lundibundi I wouldn't bother. Very few people know about this tool, even less uses it. In fact, before you, I'm was the only contributor to it.

TimothyGu
TimothyGu reviewed Aug 3, 2018
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for just make it always on.

@lundibundi
Copy link
Member Author

Now that I think of it, how should I update the plot in benchmarks guide, will it be okay to just put node master string_decode benchmarks there? (Also, maybe csv used in there is available somewhere?).
Or maybe it's fine to let it be like this (without lines)?

@TimothyGu
Copy link
Member

how should I update the plot in benchmarks guide, will it be okay to just put node master string_decode benchmarks there

Yeah, if you could just rerun the benchmark that generated that plot and update the graph that'd be great. I don't think the CSV used for the existing graph is available anywhere as the data can be regenerated quickly.

@lundibundi
Copy link
Member Author

lundibundi commented Aug 5, 2018 •
edited
Loading

Ok, I've updated the doc. PTAL.
Also, should I add the csv in order to simplify future edits?

@TimothyGu
Copy link
Member

@lundibundi Nah, these files don't get touched often. Plus we can always regenerate.

@TimothyGu TimothyGu added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 7, 2018
@jasnell
Copy link
Member

jasnell commented Aug 12, 2018

CI failed entirely, running again: https://ci.nodejs.org/job/node-test-pull-request/16385/

@joyeecheung joyeecheung mentioned this pull request Aug 15, 2018
Closed
@lundibundi
Copy link
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/16720/

@jasnell
Copy link
Member

jasnell commented Aug 24, 2018

@lundibundi ... can you rebase this off of current master. There are some changes that need to be pulled in before this will pass CI

@lundibundi
Copy link
Member Author

@jasnell oh, forgot about that, thanks.
New CI: https://ci.nodejs.org/job/node-test-pull-request/16752/

@lundibundi
benchmark: add lines to scatter plots
c65b302 
Adds lines between the points of the same category in scatter.R plots.
@lundibundi
fixup! doc: update benchmark guide
b15fb2d
@lundibundi
Copy link
Member Author

lundibundi commented Aug 27, 2018 •
edited
Loading

One more: https://ci.nodejs.org/job/node-test-pull-request/16772/
(Rebased just in case)

Known flaky async-hooks/test-callback-error (#15985) failed.
Resume: https://ci.nodejs.org/job/node-test-pull-request/16779/

@addaleax
Copy link
Member

addaleax commented Sep 2, 2018

Landed in 7aac706

@addaleax addaleax closed this Sep 2, 2018
addaleax pushed a commit that referenced this pull request Sep 2, 2018
@lundibundi @addaleax
benchmark: add lines to scatter plots
7aac706 
Adds lines between the points of the same category in scatter.R plots.

PR-URL: #22074
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos pushed a commit that referenced this pull request Sep 2, 2018
@lundibundi @targos
benchmark: add lines to scatter plots
3500905 
Adds lines between the points of the same category in scatter.R plots.

PR-URL: #22074
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@lundibundi lundibundi deleted the add-lines-scatter branch September 3, 2018 10:59
targos pushed a commit that referenced this pull request Sep 3, 2018
@lundibundi @targos
benchmark: add lines to scatter plots
48648f5 
Adds lines between the points of the same category in scatter.R plots.

PR-URL: #22074
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@lundibundi @targos
benchmark: add lines to scatter plots
dfde87a 
Adds lines between the points of the same category in scatter.R plots.

PR-URL: #22074
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@AndreasMadsen AndreasMadsen AndreasMadsen approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lundibundi @AndreasMadsen @TimothyGu @jasnell @addaleax @apapirovski @nodejs-github-bot