deps: update V8 to 6.9 #21983

targos · 2018-07-26T07:03:39Z

Let's start a new iteration!

ETA: Sept 4th, 2018

nodejs-github-bot · 2018-07-26T07:03:40Z

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/357/pipeline

targos · 2018-07-26T07:09:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/16013/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1544/

targos · 2018-07-26T08:26:14Z

We've got a few failures!

test-postmortem-metadata

$ ./node test/v8-updates/test-postmortem-metadata.js
assert.js:84
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Missing constants: v8dbg_class_SharedFunctionInfo__end_position__int,v8dbg_class_SharedFunctionInfo__function_identifier__Object,v8dbg_class_SharedFunctionInfo__script__Object,v8dbg_class_SharedFunctionInfo__start_position_and_type__int,v8dbg_sharedfunctioninfo_start_position_mask,v8dbg_sharedfunctioninfo_start_position_shift
    at Object.<anonymous> (/home/mzasso/git/nodejs/canary/test/v8-updates/test-postmortem-metadata.js:48:8)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:266:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:596:3)

@nodejs/post-mortem

FreeBSD

03:26:10 In file included from ../deps/v8/src/asmjs/asm-parser.cc:5:
03:26:10 In file included from ../deps/v8/src/asmjs/asm-parser.h:12:
03:26:10 In file included from ../deps/v8/src/asmjs/asm-types.h:13:
03:26:10 In file included from ../deps/v8/src/zone/zone-containers.h:20:
03:26:10 ../deps/v8/src/zone/zone-allocator.h:57:5: error: no matching function for call to 'operator new'
03:26:10     new (v_p) U(std::forward<Args>(args)...);
03:26:10     ^~~
03:26:10 /usr/include/c++/v1/memory:1572:18: note: in instantiation of function template specialization 'v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
03:26:10             {__a.construct(__p, _VSTD::forward<_Args>(__args)...);}
03:26:10                  ^
03:26:10 /usr/include/c++/v1/memory:1453:14: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::__construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
03:26:10             {__construct(__has_construct<allocator_type, _Tp*, _Args...>(),
03:26:10              ^
03:26:10 /usr/include/c++/v1/unordered_map:1340:20: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
03:26:10     __node_traits::construct(__na, _VSTD::addressof(__h->__value_.__cc.first), __k);
03:26:10                    ^
03:26:10 /usr/include/c++/v1/unordered_map:1365:25: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::__construct_node_with_key' requested here
03:26:10     __node_holder __h = __construct_node_with_key(__k);
03:26:10                         ^
03:26:10 ../deps/v8/src/asmjs/asm-parser.cc:2220:35: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::operator[]' requested here
03:26:10       function_info->import->cache[*sig] = index;
03:26:10                                   ^
03:26:10 ../deps/v8/src/zone/zone.h:124:9: note: candidate function not viable: cannot convert argument of incomplete type 'void *' to 'v8::internal::Zone *'
03:26:10   void* operator new(size_t size, Zone* zone) { return zone->New(size); }
03:26:10         ^
03:26:10 1 error generated.

@nodejs/platform-freebsd

SmartOS

03:35:18 dtrace: failed to compile script src/v8ustack.d: line 402: failed to resolve V8DBG_CLASS_SHAREDFUNCTIONINFO__FUNCTION_IDENTIFIER__OBJECT: Unknown variable name
03:35:18 node_dtrace_ustack.target.mk:26: recipe for target '/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos17-64/out/Release/obj.target/node_lib/src/node_dtrace_ustack.o' failed
03:35:18 make[2]: *** [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos17-64/out/Release/obj.target/node_lib/src/node_dtrace_ustack.o] Error 1

@nodejs/platform-smartos

cjihrig · 2018-08-07T18:22:14Z

I have a patch for test/v8-updates/test-postmortem-metadata.js at cjihrig@3518de8.

@targos can you cherry-pick that over? Also cc: @bmeurer and @hashseed. Can either of you confirm that my understanding of the V8 changes is correct? The commit message has an explanation for each affected constant. If these changes are correct, I'll fix the SmartOS compilation next.

targos · 2018-08-09T04:35:07Z

I'm on holiday. Feel free to push anything to my branch

targos · 2018-08-21T12:25:32Z

@cjihrig Your patch doesn't apply cleanly. I tried to make your changes by hand but the test-postmortem-metadata still fails.

refack · 2018-08-21T15:00:04Z

@targos @hashseed Why are these necessary?

build: update to renamed inspector scripts b3e924b
tools: update inspector_protocol 45a04fb

I thought the motivation for decoupling inspector_protocol from V8 was so that we won't have to update it concurrently with V8?

targos · 2018-08-21T15:15:18Z

@refack decoupling inspector_protocol from V8 happened after I first opened this PR so b3e924b was already done. I assumed it wouldn't be a bad thing to update the tool but I can revert both commits if needed.

refack · 2018-08-21T15:23:10Z

@refack decoupling inspector_protocol from V8 happened after I first opened this PR so b3e924b was already done. I assumed it wouldn't be a bad thing to update the tool but I can revert both commits if needed.

Thank you for the answer, I just wanted to understand.
I'm still trying to understand the levels of dependency, and whether we can refactor it out completely.

cjihrig · 2018-08-22T19:57:00Z

@targos, not sure what happened, but please give cjihrig@594f6b2 a shot, it should work.

targos · 2018-08-24T13:51:07Z

@cjihrig Thanks, looks good!

targos · 2018-08-27T12:37:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/16782/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1633/

targos · 2018-08-27T13:05:05Z

@nodejs/platform-smartos v8ustack.d still needs a fix ;)

15:00:52 dtrace: failed to compile script src/v8ustack.d: line 402: failed to resolve V8DBG_CLASS_SHAREDFUNCTIONINFO__FUNCTION_IDENTIFIER__OBJECT: Unknown variable name
15:00:52 node_dtrace_ustack.target.mk:26: recipe for target '/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos17-64/out/Release/obj.target/node_lib/src/node_dtrace_ustack.o' failed

cjihrig · 2018-08-27T13:06:16Z

I'll take care of it today.

targos · 2018-08-27T14:16:45Z

@nodejs/platform-freebsd Anyone can help with the compilation failure?

https://ci.nodejs.org/job/node-test-commit-freebsd/20036/nodes=freebsd10-64/console

14:45:44 In file included from ../deps/v8/src/asmjs/asm-parser.cc:5:
14:45:44 In file included from ../deps/v8/src/asmjs/asm-parser.h:12:
14:45:44 In file included from ../deps/v8/src/asmjs/asm-types.h:13:
14:45:44 In file included from ../deps/v8/src/zone/zone-containers.h:20:
14:45:44 ../deps/v8/src/zone/zone-allocator.h:57:5: error: no matching function for call to 'operator new'
14:45:44     new (v_p) U(std::forward<Args>(args)...);
14:45:44     ^~~
14:45:44 /usr/include/c++/v1/memory:1572:18: note: in instantiation of function template specialization 'v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44             {__a.construct(__p, _VSTD::forward<_Args>(__args)...);}
14:45:44                  ^
14:45:44 /usr/include/c++/v1/memory:1453:14: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::__construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44             {__construct(__has_construct<allocator_type, _Tp*, _Args...>(),
14:45:44              ^
14:45:44 /usr/include/c++/v1/unordered_map:1340:20: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44     __node_traits::construct(__na, _VSTD::addressof(__h->__value_.__cc.first), __k);
14:45:44                    ^
14:45:44 /usr/include/c++/v1/unordered_map:1365:25: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::__construct_node_with_key' requested here
14:45:44     __node_holder __h = __construct_node_with_key(__k);
14:45:44                         ^
14:45:44 ../deps/v8/src/asmjs/asm-parser.cc:2220:35: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::operator[]' requested here
14:45:44       function_info->import->cache[*sig] = index;
14:45:44                                   ^
14:45:44 ../deps/v8/src/zone/zone.h:124:9: note: candidate function not viable: cannot convert argument of incomplete type 'void *' to 'v8::internal::Zone *'
14:45:44   void* operator new(size_t size, Zone* zone) { return zone->New(size); }
14:45:44         ^
14:45:44 1 error generated.
14:45:44 deps/v8/gypfiles/v8_base.target.mk:632: recipe for target '/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/obj.target/v8_base/deps/v8/src/asmjs/asm-parser.o' failed

cjihrig · 2018-08-28T00:37:21Z

@targos here is the commit to fix the SmartOS build: cjihrig@ea184f6

targos · 2018-08-28T08:05:13Z

Thanks again!
CI: https://ci.nodejs.org/view/All/job/node-test-commit-smartos/19858/

targos · 2018-08-31T08:44:18Z

@nodejs/platform-freebsd Anyone can help with the compilation failure?

https://ci.nodejs.org/job/node-test-commit-freebsd/20036/nodes=freebsd10-64/console

14:45:44 In file included from ../deps/v8/src/asmjs/asm-parser.cc:5:
14:45:44 In file included from ../deps/v8/src/asmjs/asm-parser.h:12:
14:45:44 In file included from ../deps/v8/src/asmjs/asm-types.h:13:
14:45:44 In file included from ../deps/v8/src/zone/zone-containers.h:20:
14:45:44 ../deps/v8/src/zone/zone-allocator.h:57:5: error: no matching function for call to 'operator new'
14:45:44     new (v_p) U(std::forward<Args>(args)...);
14:45:44     ^~~
14:45:44 /usr/include/c++/v1/memory:1572:18: note: in instantiation of function template specialization 'v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44             {__a.construct(__p, _VSTD::forward<_Args>(__args)...);}
14:45:44                  ^
14:45:44 /usr/include/c++/v1/memory:1453:14: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::__construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44             {__construct(__has_construct<allocator_type, _Tp*, _Args...>(),
14:45:44              ^
14:45:44 /usr/include/c++/v1/unordered_map:1340:20: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44     __node_traits::construct(__na, _VSTD::addressof(__h->__value_.__cc.first), __k);
14:45:44                    ^
14:45:44 /usr/include/c++/v1/unordered_map:1365:25: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::__construct_node_with_key' requested here
14:45:44     __node_holder __h = __construct_node_with_key(__k);
14:45:44                         ^
14:45:44 ../deps/v8/src/asmjs/asm-parser.cc:2220:35: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::operator[]' requested here
14:45:44       function_info->import->cache[*sig] = index;
14:45:44                                   ^
14:45:44 ../deps/v8/src/zone/zone.h:124:9: note: candidate function not viable: cannot convert argument of incomplete type 'void *' to 'v8::internal::Zone *'
14:45:44   void* operator new(size_t size, Zone* zone) { return zone->New(size); }
14:45:44         ^
14:45:44 1 error generated.
14:45:44 deps/v8/gypfiles/v8_base.target.mk:632: recipe for target '/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/obj.target/v8_base/deps/v8/src/asmjs/asm-parser.o' failed

This is the only thing blocking this update.

targos · 2018-08-31T09:00:52Z

My proposition to fix this issue: #22617

PR-URL: nodejs#21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

This commit adds an InitializeV8Platform function which calls v8_platform's Initialize to create the NodePlatform and also set the structs members. When running cctests this functions was not being called (it is called from the Start function but that function is not called by the test fixture. The motivation for adding this is that I'm guessing that embedders would might need the ability to do the same thing. Refs: nodejs/node-v8#69 PR-URL: nodejs#21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

V8 now requires ICU's regular expressions. PR-URL: nodejs#21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

V8 removed the lldbinit file. Refs: https://crrev.com/c/1127892 PR-URL: nodejs#21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

V8 improved break locations for the node --inspect-brk -e case. PR-URL: nodejs#21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

This commit updates the following postmortem metadata constant: - v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t - V8 commit: v8/v8@53d4dfc PR-URL: nodejs#21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

v8.getHeapSpaceStatistics() now includes new_large_object_space in its results. Update test-v8-stats.js to account for this. Refs: v8/v8@a383aa3 PR-URL: nodejs#21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

The V8 6.9 update requires the following adjustments to the postmortem debugging metadata constants: - v8dbg_class_SharedFunctionInfo__function_identifier__Object Use: v8dbg_class_SharedFunctionInfo__function_identifier_or_debug_info__Object - v8dbg_class_SharedFunctionInfo__end_position__int Use: v8dbg_class_UncompiledData__end_position__int32_t - v8dbg_class_SharedFunctionInfo__start_position_and_type__int Use: v8dbg_class_UncompiledData__start_position__int32_t - v8dbg_sharedfunctioninfo_start_position_mask and - v8dbg_sharedfunctioninfo_start_position_shift Removed. Use: v8dbg_class_UncompiledData__start_position__int32_t - v8dbg_scopeinfo_idx_nstacklocals has been removed Refs: v8/v8@39e2d97 Refs: v8/v8@467eb14 Refs: v8/v8@c51bcd1 PR-URL: nodejs#21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

This commit renames V8DBG_CLASS_SHAREDFUNCTIONINFO__FUNCTION_IDENTIFIER__OBJECT to V8DBG_CLASS_SHAREDFUNCTIONINFO__FUNCTION_IDENTIFIER_OR_DEBUG_INFO__OBJECT following an upstream V8 change. PR-URL: nodejs#21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos · 2018-09-07T19:09:45Z

Thank you Matteo!

Landed in 12ed7c9...dbf7203

addaleax · 2018-09-14T18:14:02Z

@targos Do we want to investigate backporting to Node 10? This comes with semver-major changes on Node’s side as well, forced by V8 changes, so it would definitely be tricky.

PR-URL: nodejs/node#21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Jul 26, 2018

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 26, 2018

This was referenced Jul 26, 2018

Missing postmortem constants nodejs/node-v8#70

Closed

Compilation failure on SmartOS nodejs/node-v8#73

Closed

targos added the blocked PRs that are blocked by other issues or PRs. label Jul 26, 2018

targos force-pushed the v8-6.9 branch from cba859b to b5a187b Compare August 4, 2018 19:25

targos force-pushed the v8-6.9 branch 2 times, most recently from 07104cc to e0e740d Compare August 21, 2018 12:23

targos force-pushed the v8-6.9 branch from 8928fe8 to 295ece7 Compare August 24, 2018 13:34

targos force-pushed the v8-6.9 branch from 0e5c8fd to b80eb60 Compare August 31, 2018 08:40

targos closed this Sep 7, 2018

targos deleted the v8-6.9 branch September 7, 2018 19:09

refack mentioned this pull request Sep 13, 2018

Investigate flaky test-http-same-map on debug builds #22775

Closed

mmarchini mentioned this pull request Sep 17, 2018

[v8.x backport] deps: backport 9a23bdd from upstream V8 #22418

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 6.9 #21983

deps: update V8 to 6.9 #21983

targos commented Jul 26, 2018

nodejs-github-bot commented Jul 26, 2018

targos commented Jul 26, 2018

targos commented Jul 26, 2018 •

edited

Loading

cjihrig commented Aug 7, 2018

targos commented Aug 9, 2018

targos commented Aug 21, 2018

refack commented Aug 21, 2018

targos commented Aug 21, 2018

refack commented Aug 21, 2018

cjihrig commented Aug 22, 2018

targos commented Aug 24, 2018

targos commented Aug 27, 2018

targos commented Aug 27, 2018

cjihrig commented Aug 27, 2018

targos commented Aug 27, 2018

cjihrig commented Aug 28, 2018

targos commented Aug 28, 2018

targos commented Aug 31, 2018

targos commented Aug 31, 2018

targos commented Sep 7, 2018

addaleax commented Sep 14, 2018

deps: update V8 to 6.9 #21983

deps: update V8 to 6.9 #21983

Conversation

targos commented Jul 26, 2018

nodejs-github-bot commented Jul 26, 2018

targos commented Jul 26, 2018

targos commented Jul 26, 2018 • edited Loading

test-postmortem-metadata

FreeBSD

SmartOS

cjihrig commented Aug 7, 2018

targos commented Aug 9, 2018

targos commented Aug 21, 2018

refack commented Aug 21, 2018

targos commented Aug 21, 2018

refack commented Aug 21, 2018

cjihrig commented Aug 22, 2018

targos commented Aug 24, 2018

targos commented Aug 27, 2018

targos commented Aug 27, 2018

cjihrig commented Aug 27, 2018

targos commented Aug 27, 2018

cjihrig commented Aug 28, 2018

targos commented Aug 28, 2018

targos commented Aug 31, 2018

targos commented Aug 31, 2018

targos commented Sep 7, 2018

addaleax commented Sep 14, 2018

targos commented Jul 26, 2018 •

edited

Loading