Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove usc-2 encoding #21964

Closed
wants to merge 1 commit into from
Closed

lib: remove usc-2 encoding #21964

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jul 25, 2018 •
edited
Loading

Fixes: #21963

CI: https://ci.nodejs.org/job/node-test-pull-request/16000/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Jul 25, 2018
@nodejs-github-bot
Copy link
Collaborator

@mscdex build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/345/pipeline

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jul 25, 2018
@mscdex mscdex removed the util Issues and PRs related to the built-in util module. label Jul 25, 2018
@devsnek devsnek requested a review from BridgeAR July 25, 2018 04:57
ChALkeR
ChALkeR approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That looks to be introduced in 10.0 and removing it shouldn't affect any userland libs.

This should either land after #21965, or land with it, or should include benchmark changes here.

@BridgeAR
Copy link
Member

I agree with @ChALkeR about either including that change here or landing the other PR first.

@BridgeAR BridgeAR mentioned this pull request Jul 25, 2018
Closed
4 tasks
@mscdex
Copy link
Contributor Author

mscdex commented Jul 25, 2018 •
edited
Loading

I've included the benchmark changes now.

New CI: https://ci.nodejs.org/job/node-test-pull-request/16002/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 27, 2018
@addaleax
Copy link
Member

Landed in ce5157b

@addaleax addaleax closed this Jul 27, 2018
addaleax pushed a commit that referenced this pull request Jul 27, 2018
@mscdex @addaleax
lib: remove usc-2 encoding
ce5157b 
Fixes: #21963
PR-URL: #21964
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex mscdex deleted the buffer-isencoding-fix branch July 27, 2018 21:08
targos pushed a commit that referenced this pull request Jul 31, 2018
@mscdex @targos
lib: remove usc-2 encoding
baf3027 
Fixes: #21963
PR-URL: #21964
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devsnek devsnek devsnek approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.