Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc : Fix incorrect method name #21908

Closed
wants to merge 1 commit into from
Closed

doc : Fix incorrect method name #21908

wants to merge 1 commit into from

Conversation

antsmartian
Copy link
Contributor

@antsmartian antsmartian commented Jul 20, 2018 •
edited
Loading

Fixes #21904

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/921/

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Jul 20, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 20, 2018
vsemozhetbyt pushed a commit that referenced this pull request Jul 20, 2018
@antsmartian @vsemozhetbyt
doc: fix incorrect method name
79e63c5 
PR-URL: #21908
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in 79e63c5
Thank you!

@antsmartian
Copy link
Contributor Author

antsmartian commented Jul 20, 2018 •
edited
Loading

Wow, that's so quick. Thanks everyone, cc @vsemozhetbyt .

@trivikr trivikr mentioned this pull request Jul 20, 2018
Closed
4 tasks
targos pushed a commit that referenced this pull request Jul 20, 2018
@antsmartian @targos
doc: fix incorrect method name
fd5a0c7 
PR-URL: #21908
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@antsmartian antsmartian deleted the 21904 branch July 20, 2018 18:02
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@antsmartian @vsemozhetbyt @lance @jasnell @cjihrig