Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move AEAD test vectors out of script #21873

Closed
wants to merge 2 commits into from
Closed

test: move AEAD test vectors out of script #21873

wants to merge 2 commits into from

Conversation

tniessen
Copy link
Member

This reduces the test by almost 700 lines (more than 50%!). This would optimally be a JSON file, but we should keep the comments, so it remains JS for now.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/308/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 18, 2018
lpinca
lpinca reviewed Jul 18, 2018
View reviewed changes
test/fixtures/aead-vectors.js
tag: 'd0c515f4d1cdd4fdac4f02ab',
tampered: true
}
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing new line :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, Windows...

@maclover7
Copy link
Contributor

Full CI: https://ci.nodejs.org/job/node-test-pull-request/15960/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 20, 2018
@tniessen
Copy link
Member Author

Thanks @maclover7! Whatever node-test-commit-custom-suites is, it failed... Resumed in https://ci.nodejs.org/job/node-test-pull-request/15964/

@tniessen
Copy link
Member Author

Landed in b2ac3af.

@tniessen tniessen closed this Jul 22, 2018
tniessen added a commit that referenced this pull request Jul 22, 2018
@tniessen
test: move AEAD test vectors out of script
b2ac3af 
PR-URL: #21873
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@maclover7
Copy link
Contributor

Whatever node-test-commit-custom-suites is, it failed...

node-test-commit-custom-suites lets you plug in different test suites to run. Looks like @Trott is working on documenting this in #21927, but I'll just add on to say that it's used to run the default test suites with the --worker flags for all node-test-commit builds, to make sure we don't break stuff with workers

@targos
Copy link
Member

targos commented Jul 24, 2018

Depends on #21447 to land on v10.x-staging

@targos targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 24, 2018
targos pushed a commit that referenced this pull request Aug 29, 2018
@tniessen @targos
test: move AEAD test vectors out of script
09a824f 
PR-URL: #21873
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos pushed a commit that referenced this pull request Sep 3, 2018
@tniessen @targos
test: move AEAD test vectors out of script
4cdc61b 
PR-URL: #21873
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@tniessen @targos
test: move AEAD test vectors out of script
a972159 
PR-URL: #21873
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@maclover7 maclover7 maclover7 approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @nodejs-github-bot @maclover7 @targos @jasnell @lpinca @trivikr