Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: name anonymous function in tls.js #21754

Closed
wants to merge 1 commit into from
Closed

tls: name anonymous function in tls.js #21754

wants to merge 1 commit into from

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Jul 11, 2018 •
edited
Loading

Refs: #8913

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Jul 11, 2018
@trivikr
Copy link
Member

trivikr commented Jul 11, 2018

Thank you @klacabane for your first PR in Node.js core! 🎉

CI: https://ci.nodejs.org/job/node-test-pull-request/15799/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 12, 2018
@trivikr
Copy link
Member

trivikr commented Jul 14, 2018

node-test-commit-linux re-run https://ci.nodejs.org/job/node-test-commit-linux/20101/

@trivikr
Copy link
Member

trivikr commented Jul 18, 2018

Landed in 07c514c

Congratulations @klacabane on your first commit in Node.js core! 🎉🎉🎉

@trivikr trivikr closed this Jul 18, 2018
trivikr pushed a commit that referenced this pull request Jul 18, 2018
@klacabane @trivikr
tls: name anonymous function in tls.js
07c514c 
Refs: #8913

PR-URL: #21754
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos pushed a commit that referenced this pull request Jul 19, 2018
@klacabane @targos
tls: name anonymous function in tls.js
0f70017 
Refs: #8913

PR-URL: #21754
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@maclover7 maclover7 maclover7 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@klacabane @trivikr @jasnell @lpinca @maclover7 @BridgeAR @nodejs-github-bot