doc: remove _Node.js style callback_ #21701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We refer to them only as _error-first callbacks_ in our docs. We don't call them _Node.js style callbacks_ so let's take this opporutnity to keep things a bit more concise
nodejs-github-bot
added
doc
apapirovski
approved these changes
Jul 7, 2018
|
👍 to fast-track. kthx |
vsemozhetbyt
approved these changes
Jul 7, 2018
vsemozhetbyt
added
the
author ready
|
The linter failure seems to be the same notorious outdated plugin issue. |
@maclover7 is aware and looking at it. FWIW, if anyone currently involved in Node.js core has the right skill set and would like to help out with our Jenkins stuff, I'm sure the Build WG would be happy to hear about it. |
|
Linter CI: https://ci.nodejs.org/job/node-linter/200/ |
|
Landed in 01eee53 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 7, 2018
We refer to them only as _error-first callbacks_ in our docs. We don't call them _Node.js style callbacks_ so let's take this opporutnity to keep things a bit more concise PR-URL: nodejs#21701 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 8, 2018
We refer to them only as _error-first callbacks_ in our docs. We don't call them _Node.js style callbacks_ so let's take this opporutnity to keep things a bit more concise PR-URL: #21701 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 9, 2018
We refer to them only as _error-first callbacks_ in our docs. We don't call them _Node.js style callbacks_ so let's take this opporutnity to keep things a bit more concise PR-URL: #21701 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We refer to them only as error-first callbacks in our docs. We don't
call them Node.js style callbacks so let's take this opporutnity to
keep things a bit more concise
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes