http2: order declarations in core.js #21689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v4.x
http2
|
Spurious lint error again. This is the second time this has happened to one of my pull requests. Something is strange with the auto-started lint jobs. /ping @maclover7 In the meantime, here's a full CI: https://ci.nodejs.org/job/node-test-pull-request/15751/ |
devsnek
approved these changes
Jul 6, 2018
starkwang
approved these changes
Jul 7, 2018
|
Windows CI re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19178/ |
Order declarations: * public modules in alphabetical order * internal modules in alphabetical order * process.binding() calls in alphabetical order * exports in alphabetical order
|
Had to resolve a conflict so here's CI again: https://ci.nodejs.org/job/node-test-pull-request/15785/ |
jasnell
approved these changes
Jul 10, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 10, 2018
Order declarations: * public modules in alphabetical order * internal modules in alphabetical order * process.binding() calls in alphabetical order * exports in alphabetical order PR-URL: nodejs#21689 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 11931ae |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2018
Order declarations: * public modules in alphabetical order * internal modules in alphabetical order * process.binding() calls in alphabetical order * exports in alphabetical order PR-URL: #21689 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jul 18, 2018
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Aug 23, 2018
Order declarations: * public modules in alphabetical order * internal modules in alphabetical order * process.binding() calls in alphabetical order * exports in alphabetical order PR-URL: nodejs#21689 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Sep 25, 2018
Order declarations: * public modules in alphabetical order * internal modules in alphabetical order * process.binding() calls in alphabetical order * exports in alphabetical order PR-URL: nodejs#21689 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
Order declarations: * public modules in alphabetical order * internal modules in alphabetical order * process.binding() calls in alphabetical order * exports in alphabetical order PR-URL: nodejs#21689 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 17, 2018
Order declarations: * public modules in alphabetical order * internal modules in alphabetical order * process.binding() calls in alphabetical order * exports in alphabetical order Backport-PR-URL: #22850 PR-URL: #21689 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how this will be received because maybe there's an ordering in there already that I'm not detecting, but I find the lengthy declarations at the start of core.js kind of arbitrary and hard to follow. This brings some ordering to it, and hopefully makes it easier to follow or at least not any more difficult to follow.
Order declarations:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes