doc: update changelog with 9.x EOL #21612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
|
Alternatively, we could remove the LTS/Current/EOL labels from the changelog whatsoever, but to my estimation those rarely need updating, but can have value for users determining which version should they use. |
targos
approved these changes
Jul 1, 2018
cjihrig
approved these changes
Jul 1, 2018
lpinca
approved these changes
Jul 1, 2018
trivikr
approved these changes
Jul 1, 2018
maclover7
approved these changes
Jul 10, 2018
maclover7
added
the
author ready
This removes unsupported versions from the table, as those might confuse people, execially given the > Release versions displayed in **bold** text represent the most > recent actively supported release. remark below. It was inconsistent to keep some of the EOL entries in the table while removing others (v5.x, v7.x) -- this commit takes care of that. Instead, release status is hinted in the branch list above, highlighting two main branches -- Current and Active LTS. Also update the link to the Release repo. Refs: nodejs/Release#351 PR-URL: nodejs#21612 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
|
Landed in 195480a. |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2018
This removes unsupported versions from the table, as those might confuse people, execially given the > Release versions displayed in **bold** text represent the most > recent actively supported release. remark below. It was inconsistent to keep some of the EOL entries in the table while removing others (v5.x, v7.x) -- this commit takes care of that. Instead, release status is hinted in the branch list above, highlighting two main branches -- Current and Active LTS. Also update the link to the Release repo. Refs: nodejs/Release#351 PR-URL: #21612 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
This was referenced Jul 18, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unsupported versions from the table, as those might confuse people,
especially given the
remark below.
It was inconsistent to keep some of the EOL entries in the table while
removing others (v5.x, v7.x) -- this commit takes care of that.
Instead, release status is hinted in the branch list above, highlighting
two main branches -- Current and Active LTS.
Also update the link to the Release repo.
Refs: nodejs/Release#351
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes