Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace third argument with comment in strict equals #21603

Closed
wants to merge 1 commit into from
Closed

test: replace third argument with comment in strict equals #21603

wants to merge 1 commit into from

Conversation

learnitmyway
Copy link

@learnitmyway learnitmyway commented Jun 30, 2018

As suggested by @Trott as a good first issue, this PR replaces the the third argument of a strictEqual with a comment.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 30, 2018
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t worry about the red CI, we have a broken master right now … :(

@Trott
Copy link
Member

Trott commented Jul 1, 2018

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 1, 2018
trivikr pushed a commit that referenced this pull request Jul 4, 2018
PR-URL: #21603
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@trivikr
Copy link
Member

trivikr commented Jul 4, 2018

Landed in ecba4fa

Congratulations @developerdavo on your first commit in Node.js core! 🎉🎉🎉

@trivikr trivikr closed this Jul 4, 2018
@learnitmyway
Copy link
Author

😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants