Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: use compileFunction over Module.wrap #21573

Closed
wants to merge 16 commits into from
Closed

module: use compileFunction over Module.wrap #21573

wants to merge 16 commits into from

Commits on Jan 29, 2019

  1. module: use compileFunction over Module.wrap 

    Use vm.compileFunction (which is a binding for
v8::CompileFunctionInContext) instead of Module.wrap internally in
Module._compile for the cjs loader.

Fixes: nodejs#17396
    @ryzokuken
    ryzokuken committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    113d0b7 View commit details
    Browse the repository at this point in the history

  2. module: revert module._compile to original state if module is patched

    @ryzokuken
    ryzokuken committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    7cf60fb View commit details
    Browse the repository at this point in the history

  3. fixup! module: revert module._compile to original state if module is … 

    …patched
    @ryzokuken
    ryzokuken committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    c352906 View commit details
    Browse the repository at this point in the history

  4. fixup! module: revert module._compile to original state if module is … 

    …patched
    @ryzokuken
    ryzokuken committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    3146e19 View commit details
    Browse the repository at this point in the history

  5. fixup! module: revert module._compile to original state if module is … 

    …patched
    @ryzokuken
    ryzokuken committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    15db986 View commit details
    Browse the repository at this point in the history

  6. fixup! module: revert module._compile to original state if module is … 

    …patched
    @ryzokuken
    ryzokuken committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    ed4af45 View commit details
    Browse the repository at this point in the history

  7. assert and coverage test fixes

    @guybedford @ryzokuken
    guybedford authored and ryzokuken committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    8008e59 View commit details
    Browse the repository at this point in the history

  8. attempt to fix dynamic imports

    @ryzokuken
    ryzokuken committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    687d82c View commit details
    Browse the repository at this point in the history

  9. patch up dynamic import without introducing a memory leak

    @guybedford @ryzokuken
    guybedford authored and ryzokuken committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    9a152a3 View commit details
    Browse the repository at this point in the history

  10. fix wrap typo

    @ryzokuken
    ryzokuken committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    cb604f2 View commit details
    Browse the repository at this point in the history

  11. add test for Module.wrap interception

    @guybedford @ryzokuken
    guybedford authored and ryzokuken committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    9fbbd27 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2019

  1. use internal compileFunction binding in CJS wrap

    @guybedford
    guybedford committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    09cc845 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2019

  1. use node persistent

    @guybedford
    guybedford committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    35e209e View commit details
    Browse the repository at this point in the history

  2. fix compileFunction memory leak

    @guybedford
    guybedford committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    9284715 View commit details
    Browse the repository at this point in the history

  3. memory leak fix feedback

    @guybedford
    guybedford committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    ba89f2d View commit details
    Browse the repository at this point in the history

  4. whitespace

    @guybedford
    guybedford committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    b35b5ee View commit details
    Browse the repository at this point in the history