Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: handle undefined filename in getErrMessage #20848

Closed
wants to merge 1 commit into from
Closed

assert: handle undefined filename in getErrMessage #20848

wants to merge 1 commit into from

Commits on May 21, 2018

  1. assert: handle undefined filename in getErrMessage 

    When generating an assertion error message,
`filename` might be undefined,
e.g. if `assert` is called in `eval`.

Handle this case gracefully instead of failing with
`Cannot read property 'endsWith' of undefined`.

Fixes: nodejs#20847
    @jeysal
    jeysal committed May 21, 2018
    Configuration menu
    Copy the full SHA
    0118fcd View commit details
    Browse the repository at this point in the history