benchmark: fix typo in README #2067
Conversation
mscdex
added
doc
|
LGTM |
| @@ -9,7 +9,7 @@ Most of the http benchmarks require [`wrk`][wrk] and [`ab`][ab] (ApacheBench) be | |||
| These may be available through your preferred package manager. | |||
|
|
|||
| If they are not available: | |||
| - `wrk` may easily built [from source](https://github.com/wg/wrk) via `make`. | |||
| - `wrk` may be easily built [from source](https://github.com/wg/wrk) via `make`. | |||
There was a problem hiding this comment.
Haha, oops. While you are at it, could you change the source link to be [from source][wrk]? Thanks!
|
LGTM |
|
👍 Just make sure the link works in a markdown viewer if you can. (I'm not used to those.) Also, maybe it should be "may easily be" instead of "may be easily"? I dunno, I'm tired haha. |
|
I checked the link here: https://github.com/Trott/io.js/blob/benchmark-typo/benchmark/README.md As for "may easily be built from source via make" vs. "may be easily built from source via make", how about we opt for dropping the "easily" altogether and going with "may be built from source via make"? |
|
I also prefer 'may easily be built from source'. |
|
Pushed a change with "easily" moved to the desired location per @Fishrock123 & @ofrobots |
PR-URL: #2067 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Thanks. Landed: f52d733. |
PR-URL: nodejs#2067 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
No description provided.