Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: force require('process') to return a reference to process #206

Closed
wants to merge 1 commit into from

Conversation

lxe
Copy link

@lxe lxe commented Dec 23, 2014

This makes require('process') always return a reference to the global process object. Fixes #157

@vkurchatkin
Copy link
Contributor

Why not module.exports = global.process?

@lxe
Copy link
Author

lxe commented Dec 23, 2014

@vkurchatkin there were a few ways to do this... making lib/process.js with module.exports = process is certainly one of them, and I wasn't sure which one would look more like a hack. We're already removing lib/sys which did the one-line re-export, so I was thinking we probably shouldn't create whole files just to do a re-export.

@bnoordhuis
Copy link
Member

I prefer the lib/process.js approach. Anything that doesn't require hacking lib/module.js.

@lxe
Copy link
Author

lxe commented Dec 23, 2014

@bnoordhuis added lib/process.js instead of the conditionals.

@@ -0,0 +1,25 @@
// Copyright Joyent, Inc. and other Node contributors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to either // Copyright io.js contributors or your own / your company's name?

@bnoordhuis
Copy link
Member

LGTM technically but as the discussion in #157 doesn't appear to have reached a conclusion, I won't merge it straight away. I'll bring it up at the next TC meeting unless enough TC members +1 it before that.

@lxe
Copy link
Author

lxe commented Dec 25, 2014

Happy holidays everyone!

@bnoordhuis
Copy link
Member

@lxe Still one nit but if you fix that, I'll land it. Thanks.

This makes require('process') always return a reference to the global
process object.
@lxe
Copy link
Author

lxe commented Dec 30, 2014

@bnoordhuis totally missed that one! Thanks.

bnoordhuis pushed a commit that referenced this pull request Dec 30, 2014
This makes require('process') always return a reference to the global
process object.

PR-URL: #206
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis
Copy link
Member

Cheers Aleksey, landed in d8586ea. I had to reword the first line to make it fit in 50 columns. Thanks!

@bnoordhuis bnoordhuis closed this Dec 30, 2014
@lxe
Copy link
Author

lxe commented Dec 30, 2014

Great stuff @bnoordhuis. thank you!

@rvagg
Copy link
Member

rvagg commented Jan 2, 2015

ftr, agreed to merge this in TC meeting 2014-12-30 #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants