test: add fs/promises filehandle sync() and datasync() tests. #20530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
May 6, 2018
ChALkeR
reviewed
May 6, 2018
| await handle.datasync(); | ||
| await handle.sync(); | ||
| const buf = Buffer.from('hello world'); | ||
| await write(handle, buf); |
There was a problem hiding this comment.
handle.write(buf)?
Same results and coverage, also see #20559.
ChALkeR
reviewed
May 6, 2018
| await handle.sync(); | ||
| const buf = Buffer.from('hello world'); | ||
| await write(handle, buf); | ||
| const ret = await read(handle, Buffer.alloc(11), 0, 11, 0); |
There was a problem hiding this comment.
read(handle → handle.read(? See the comment above.
There was a problem hiding this comment.
@ChALkeR Fixed them. Thanks.
ChALkeR
added
experimental
shisama
force-pushed
the
test-fs-promises-file-handle-sync
branch
from
1ff5b56 to
e8f8408
Compare
|
/cc @Trott |
shisama
force-pushed
the
test-fs-promises-file-handle-sync
branch
from
5784c2d to
2b54d4a
Compare
|
This is rebased on 0300f7c. |
|
@nodejs/fs please give this a look and a review, if possible. It's been over a month. |
joyeecheung
approved these changes
Jun 10, 2018
| assert.deepStrictEqual(ret.buffer, buf); | ||
| } | ||
|
|
||
| validateSync().then(common.mustCall()); |
There was a problem hiding this comment.
common.mustCall() here seems unnecessary. If anything, common.crashOnUnhandledRejection() above gives a better hint about why it fails.
There was a problem hiding this comment.
@joyeecheung Thanks. Removed common.mustCall().
added 4 commits
June 10, 2018 16:37
To increase test coverage for fs/promises, added tests for filehandle.sync and filehandle.datasync.
Replacing fs/promises methods read and write with fs/promises filehandle methods.
Fix module loading because fs/promises was moved to fs.promises
shisama
force-pushed
the
test-fs-promises-file-handle-sync
branch
from
2b54d4a to
d462d2c
Compare
apapirovski
added
the
author ready
|
CI failure is not related to this. It happens in |
|
I think CI failure |
cjihrig
approved these changes
Jul 7, 2018
targos
pushed a commit
to targos/node
that referenced
this pull request
Jul 15, 2018
To increase test coverage for fs.promises, added tests for filehandle.sync and filehandle.datasync. PR-URL: nodejs#20530 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 71ca076. Thanks for the contribution @shisama. |
targos
removed
the
author ready
targos
pushed a commit
that referenced
this pull request
Jul 15, 2018
To increase test coverage for fs.promises, added tests for filehandle.sync and filehandle.datasync. PR-URL: #20530 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase test coverage for fs/promises,
added tests for filehandle.sync and filehandle.datasync.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes