v8: cherry-pick uclibc build patch from upstream #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
LGTM |
|
lgtm |
Original commit log follows:
Restore V8_LIBC_UCLIBC as a libc option.
As uClibc defines __GLIBC__ in an attempt to look like glibc,
V8_LIBC_GLIBC was true for uClibc as well. Checking for uClibc
before glibc fixes this and restores the correct behavior.
Review URL: https://codereview.chromium.org/1066573005
Fixes: nodejs#1432
PR-URL: nodejs#1974
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis
force-pushed
the
cherry-pick-uclibc-patch
branch
from
d62150f
to
4b4b176
Compare
|
Thanks, landed in 4b4b176. There are some failures on the freebsd buildbots but they seem to be caused by a stray process hogging a TCP port. |
This was referenced Apr 24, 2023
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit log follows:
Fixes: #1432
R=@jbergstroem or @rvagg?
CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/842/