Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: fix freeze if util.inspect throws & clean up error handling a bit #1968

Closed
wants to merge 2 commits into from
Closed

repl: fix freeze if util.inspect throws & clean up error handling a bit #1968

wants to merge 2 commits into from

Commits on Jun 13, 2015

  1. repl: ensure eval serialization does not throw 

    If an error is thrown during the readline `keypress` event, the state of
the streaming escape sequence decoder (added in
#1601) will become corrupted. This
will render the REPL (and possibly your whole terminal) completely
unusable. This can be triggered by an object with a custom `inspect`
method that throws.

This commit adds an extra try/catch around `self.writer` (which is
`util.inspect` by default).
    @monsanto
    monsanto committed Jun 13, 2015
    Configuration menu
    Copy the full SHA
    2380c93 View commit details
    Browse the repository at this point in the history

  2. repl: cleanup error handling

    @monsanto
    monsanto committed Jun 13, 2015
    Configuration menu
    Copy the full SHA
    03aa4a0 View commit details
    Browse the repository at this point in the history