Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: reorder authors #1966

Closed
wants to merge 1 commit into from
Closed

Conversation

jbergstroem
Copy link
Member

Make the order of name, email and other additions simpler to copy paste and/or match with git commit messages.

Useful when working with Reviewed-By.

@jbergstroem jbergstroem added the doc Issues and PRs related to the documentations. label Jun 13, 2015
@rvagg
Copy link
Member

rvagg commented Jun 13, 2015

I've been thinking that maybe putting them in full alphabetical order would be best, TC members included, it decreases the importance of the TC slightly which I think is appropriate for how this project actually works.

Thoughts anyone?

@jbergstroem
Copy link
Member Author

@rvagg How about chopping up similar to:

Current Project Team Members
Technical committee
  • a-z
Plebs
  • a-z

@monsanto
Copy link
Contributor

+1 to the PR and to alphabetical order, no opinion on separating TC from collaborators

@rvagg
Copy link
Member

rvagg commented Jun 13, 2015

@jbergstroem that's compounding the problem! I'd like it if it were shown that TC members are just collaborators that get to have a meeting every week rather than some special external group.

@jbergstroem
Copy link
Member Author

@rvagg I don't really feel that way but I have no strong opinion in the matter. Happy to reorder on top of this PR. Lets see how it goes.

Edit: Sort by first- or last name? How would we handle non-latin names?

@monsanto
Copy link
Contributor

I think: Sort by last name, non-Latin names should be placed where their transliterated name would go

@rlidwka
Copy link
Contributor

rlidwka commented Jun 13, 2015

Sorting by the last name doesn't make much sense.

Imho, it's either case-insensitive sort by full name (non-Latin at the bottom), or just sort by a nickname bypassing the whole issue altogether.

@Trott
Copy link
Member

Trott commented Jun 13, 2015

+1 to sorting on GitHub handle. That avoids a host of issues.

EDIT: The corner cases I'd want to avoid are:

  • Disambiguating and ordering people with the same name.
  • How to order people whose "first name" is their family name and "last name" is their personal name.
  • How to order people who have only one name rather than a first name and last name.

Using GitHub nicknames avoids all this. It's also more diversity-friendly, in my opinion.

@sam-github
Copy link
Contributor

It would help me if they were sorted by github handle, and the text after the github handle was exactly what needs to be pasted into commit messages in the Reviewed-By field: First Last this@that`. Its annoyingly difficult finding that information from just the github handle ATM.

@trevnorris
Copy link
Contributor

I'm not opposed to reordering the names, but saying it'll help find someone is not really an argument. Don't think a text editor exists today that anyone would use that doesn't have text search. And finding their information for a Reviewed-By isn't difficult either. If they can LGTM, they've committed before and it can be found in git log.

In any case, I'd vote to sort by name. Handles and emails can more easily change then a person's name.

@jbergstroem
Copy link
Member Author

Since we don't seem to have a consensus on naming I suggest I revert the ordering and we proceed with what I originally set out to do, which was helping people using reviewed-by/git logs. Thoughts?

@rvagg
Copy link
Member

rvagg commented Jun 14, 2015

which is just about switching email & github handle so you can copypasta? sounds like a plan

@jbergstroem
Copy link
Member Author

@rvagg yeah. I'll back out my ordering commit so we can get LGTM's going.

Edit: Rebased.

Make the order of name, email and other additions simpler to
copy paste and/or match with git commit messages.

Useful when working with `Reviewed-By`.
@jbergstroem
Copy link
Member Author

Can we get a LGTM :)

@tellnes
Copy link
Contributor

tellnes commented Jun 16, 2015

I'm not a native english speaker, but is reorder authors the correct wording in the commit message since it does not change the order of authors anymore?

Otherwise, LGTM.

@bnoordhuis
Copy link
Member

LGTM but I second the observation about 'reorder authors'. Maybe doc: reformat authors section?

@jbergstroem
Copy link
Member Author

Ok. Will modify commit message

@jbergstroem
Copy link
Member Author

@tellnes your gitconfig seems to differ from what we have in README.md

jbergstroem added a commit that referenced this pull request Jun 17, 2015
Make the order of name, email and other additions simpler to
copy paste and/or match with git commit messages.

Useful when working with `Reviewed-By`.

PR-URL: #1966
Reviewed-By: Christian Tellnes <christian@tellnes.no>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jbergstroem
Copy link
Member Author

Merged in c4ec041. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants