test: remove custom error message #19526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default error message contains the actual and expected values, which is more informative than the custom error message to be deleted.
Trott
approved these changes
Mar 22, 2018
Leko
approved these changes
Mar 22, 2018
richardlau
approved these changes
Mar 22, 2018
tniessen
approved these changes
Mar 22, 2018
cjihrig
approved these changes
Mar 22, 2018
lpinca
added
the
author ready
jasnell
approved these changes
Mar 23, 2018
|
Ci failures are unrelated build issues. Linux CI re-run: https://ci.nodejs.org/job/node-test-commit-linux/17292/ ARM fanned CI re-run: https://ci.nodejs.org/job/node-test-commit-arm-fanned/15341/ |
|
Landed in 85a3d82, thank you! 🎉 |
tniessen
pushed a commit
that referenced
this pull request
Mar 25, 2018
Default error message contains the actual and expected values, which is more informative than the custom error message to be deleted. PR-URL: #19526 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Thank you! It feels good to start contributing to NodeJS! |
targos
pushed a commit
that referenced
this pull request
Mar 27, 2018
Default error message contains the actual and expected values, which is more informative than the custom error message to be deleted. PR-URL: #19526 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default error message contains the actual and expected values,
which is more informative than the custom error message to be deleted.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test