Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix upcoming v8 deprecation warnings #19490

Closed
wants to merge 2 commits into from
Closed

src: fix upcoming v8 deprecation warnings #19490

wants to merge 2 commits into from

Conversation

SirR4T
Copy link
Contributor

@SirR4T SirR4T commented Mar 20, 2018

Fixes: #18909

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 20, 2018
TimothyGu
TimothyGu approved these changes Mar 23, 2018
View reviewed changes
src/node.cc Outdated
@@ -1269,9 +1269,12 @@ void AppendExceptionLine(Environment* env,
ScriptOrigin origin = message->GetScriptOrigin();
node::Utf8Value filename(env->isolate(), message->GetScriptResourceName());
const char* filename_string = *filename;
int linenum = message->GetLineNumber();
Maybe<int> line_number_maybe = message->GetLineNumber(env->context());
int linenum = line_number_maybe.FromJust();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no need for a separate line_number_maybe variable.

@TimothyGu
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13830/

@targos
Copy link
Member

targos commented Mar 23, 2018

Landed in c6c957d. Thanks!

@targos targos closed this Mar 23, 2018
targos pushed a commit that referenced this pull request Mar 23, 2018
@SirR4T @targos
src: fix upcoming V8 deprecation warnings
c6c957d 
PR-URL: #19490
Fixes: #18909
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2018
@SirR4T @targos
src: fix upcoming V8 deprecation warnings
cae9ff2 
PR-URL: #19490
Fixes: #18909
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Apr 4, 2018
Merged
blattersturm pushed a commit to citizenfx/node that referenced this pull request Nov 3, 2018
@SirR4T @blattersturm
src: fix upcoming V8 deprecation warnings
af07964 
PR-URL: nodejs#19490
Fixes: nodejs#18909
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V8: upcoming deprecation warnings
5 participants
@SirR4T @TimothyGu @targos @danbev @nodejs-github-bot