http2: eliminate unnecessary nextTicks, use stream close event #19451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streams were recently updated to emit their own close event. The Http2Stream was an exception because it included the close argument with the close event. Refactor that to use the built in close.
nodejs-github-bot
added
dont-land-on-v4.x
http2
|
Failure in CI is unrelated. |
jasnell
added a commit
that referenced
this pull request
Mar 22, 2018
PR-URL: #19451 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
added a commit
that referenced
this pull request
Mar 22, 2018
Streams were recently updated to emit their own close event. The Http2Stream was an exception because it included the close argument with the close event. Refactor that to use the built in close. PR-URL: #19451 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 24, 2018
PR-URL: #19451 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
I think commit 2 depends on #18438 (semver-major). Marking dont-land-on-v9.x |
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#19451 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Http2Stream/cc @addaleax @mcollina @mafintosh
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes