Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: introduce make jstest #19324

Closed
wants to merge 1 commit into from
Closed

Conversation

joyeecheung
Copy link
Member

Add a make jstest target that runs tests written in JavaScript
(excluding documentation tests which are run in make test-doc).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Add a `make jstest` target that runs tests written in JavaScript
(excluding documentation tests which are run in `make test-doc`).
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Mar 13, 2018
@Trott
Copy link
Member

Trott commented Mar 13, 2018

Any reason not to add the same feature to vcbuild.bat?

@joyeecheung
Copy link
Member Author

@Trott Just me being bad at Windows batch scripts..? I could not find a cctest there either

@bzoz
Copy link
Contributor

bzoz commented Mar 15, 2018

There is no-cctest which I guess would be similar to jstest. I can pick this up and make jstest and cctest for vcbuild

@gibfahn
Copy link
Member

gibfahn commented Mar 19, 2018

Wouldn't this make more sense as test-js?

@joyeecheung
Copy link
Member Author

@gibfahn

Mostly because cctest v.s. jstest

@bzoz
Copy link
Contributor

bzoz commented Mar 19, 2018

BTW, there is vcbuild no-cctest. It is for skipping cctest compilation. Running vcbuild no-cctest test would basically be the same as make jstest

@gibfahn
Copy link
Member

gibfahn commented Mar 19, 2018

Mostly because cctest v.s. jstest

Hmm okay. I'd probably still go with test-js for consistency with all the other targets, and consider changing cctest to test-cc in a later PR.

Existing list is:

coverage-test
cctest
list-gtests
test
test-only
test-cov
test-parallel
test-valgrind
test-check-deopts
test-gc
test-gc-clean
test-build
test-build-addons-napi
test-all
test-all-valgrind
test-ci-native
test-ci-native
test-ci-js
test-ci
test-ci
test-release
test-debug
test-message
test-simple
test-pummel
test-internet
test-node-inspect
test-tick-processor
test-hash-seed
test-doc
test-known-issues
test-npm
test-npm-publish
test-addons-napi
test-addons-napi-clean
test-addons
test-addons-clean
test-timers
test-timers-clean
test-async-hooks
test-with-async-hooks
test-v8
test-v8-intl
test-v8-benchmarks
test-v8-all

@joyeecheung
Copy link
Member Author

@joyeecheung
Copy link
Member Author

Landed in 2f8df6b, thanks!

@joyeecheung joyeecheung closed this Apr 4, 2018
joyeecheung added a commit that referenced this pull request Apr 4, 2018
Add a `make jstest` target that runs tests written in JavaScript
(excluding documentation tests which are run in `make test-doc`).

PR-URL: #19324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
targos pushed a commit that referenced this pull request Apr 4, 2018
Add a `make jstest` target that runs tests written in JavaScript
(excluding documentation tests which are run in `make test-doc`).

PR-URL: #19324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@targos targos mentioned this pull request Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants