Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] doc: add new documentation rule #19065

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] doc: add new documentation rule #19065

wants to merge 1 commit into from

Conversation

estrada9166
Copy link
Contributor

Backporting doc changes.
Refs: #18981
Refs: #18726 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. v8.x labels Mar 1, 2018
@gibfahn gibfahn self-assigned this Mar 5, 2018
@gibfahn
Copy link
Member

gibfahn commented Mar 20, 2018

@MylesBorins MylesBorins added the blocked PRs that are blocked by other issues or PRs. label Mar 21, 2018
@MylesBorins
Copy link
Contributor

@estrada9166 this has not yet landed on v9.x, we won't be able to land on v8.x until it has landed

also can you please retain all the original meta data of the initial commit including the sign off data

@estrada9166
Copy link
Contributor Author

estrada9166 commented Mar 21, 2018

@MylesBorins I'm waiting some opinions on this PR (It'll check that all the dependencies related to make lint-md are installed and will prevent this error) so we can land the one of the v9.x...

Thank you so much for your comments!

@MylesBorins MylesBorins force-pushed the v8.x-staging branch 2 times, most recently from 44cb0d3 to 16bf5fe Compare March 30, 2018 03:28
@MylesBorins MylesBorins force-pushed the v8.x-staging branch 2 times, most recently from 5ac4bac to 591812f Compare May 22, 2018 15:31
@MylesBorins
Copy link
Contributor

I'm closing this. We can reopen or make a new PR when upstream change lands

@MylesBorins MylesBorins closed this Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants