Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x] backport 17338, 18186, 18358, 18546 #18916

Closed
wants to merge 5 commits into from
Closed

[v9.x] backport 17338, 18186, 18358, 18546 #18916

wants to merge 5 commits into from

Commits on Feb 22, 2018

  1. src: expose uv.errmap to binding 

    Add a errno -> [error code, uv error message] map to the uv binding
so the error message can be assembled in the JS layer.

PR-URL: nodejs#17338
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @joyeecheung
    joyeecheung committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    017013a View commit details
    Browse the repository at this point in the history

  2. util: implement util.getSystemErrorName() 

    Reimplement uv.errname() as internal/util.getSystemErrorName() to
avoid the memory leaks caused by unknown error codes
and avoid calling into C++ for the error names. Also
expose it as a public API for external use.

PR-URL: nodejs#18186
Refs: http://docs.libuv.org/en/v1.x/errors.html#c.uv_err_name
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @joyeecheung
    joyeecheung committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    3b18dae View commit details
    Browse the repository at this point in the history

  3. errors: improve the description of ERR_INVALID_ARG_VALUE 

    - Allow user to customize why the argument is invalid
- Display the argument with util.inspect so null bytes can be
  displayed properly.

PR-URL: nodejs#18358
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
    @joyeecheung
    joyeecheung committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    a2a2f06 View commit details
    Browse the repository at this point in the history

  4. util: skip type checks in internal getSystemErrorName 

    PR-URL: nodejs#18546
Reviewed-By: James M Snell <jasnell@gmail.com>
    @joyeecheung
    joyeecheung committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    8006e0b View commit details
    Browse the repository at this point in the history

  5. errors: move error creation helpers to errors.js 

    This commit moves error creation helpers scattered around
under lib/ into lib/internal/errors.js in the hope of being clearer
about the differences of errors that we throw into the user land.

- Move util._errnoException and util._exceptionWithHostPort
  into internal/errors.js and simplify their logic so it's
  clearer what the properties these helpers create.
- Move the errnoException helper in dns.js to internal/errors.js
  into internal/errors.js and rename it to dnsException. Simplify
  it's logic so it no longer calls errnoException and skips
  the unnecessary argument checks.

PR-URL: nodejs#18546
Reviewed-By: James M Snell <jasnell@gmail.com>
    @joyeecheung
    joyeecheung committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    714c529 View commit details
    Browse the repository at this point in the history