Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libuv] upgrade to 1.6.0 #1889

Closed
wants to merge 2 commits into from
Closed

[libuv] upgrade to 1.6.0 #1889

wants to merge 2 commits into from

Conversation

saghul
Copy link
Member

@saghul saghul commented Jun 3, 2015

saghul added 2 commits June 3, 2015 21:34
Revert "dgram: call send callback asynchronously" partially, since the
fix is now done in libuv.

Refs: nodejs#1313
Refs: libuv/libuv#371
@saghul
Copy link
Member Author

saghul commented Jun 3, 2015

While the convergence process takes place, should I also PR joyent/node ?

@bnoordhuis
Copy link
Member

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/762/

While the convergence process takes place, should I also PR joyent/node ?

@misterdjules ^

@cjihrig
Copy link
Contributor

cjihrig commented Jun 3, 2015

I'd like to run the CI again since #1881 landed. That commit should fix most of the red, and I want to see if the other two failures were flakey.

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/764/

@cjihrig
Copy link
Contributor

cjihrig commented Jun 3, 2015

Looks like test-net-server-max-connections-close-makes-more-available.js might still be a problem, but it's not related to the libuv update. Rubber stamp LGTM

bnoordhuis pushed a commit that referenced this pull request Jun 3, 2015
Fixes: nodejs/node-v0.x-archive#9310
PR-URL: #1889
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
bnoordhuis pushed a commit that referenced this pull request Jun 3, 2015
Revert "dgram: call send callback asynchronously" partially, since the
fix is now done in libuv.

Refs: #1313
Refs: libuv/libuv#371
PR-URL: #1889
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@bnoordhuis
Copy link
Member

Cheers Saúl, landed in a804026...b5cd2f0.

@bnoordhuis bnoordhuis closed this Jun 3, 2015
@rvagg
Copy link
Member

rvagg commented Jun 3, 2015

@saghul || @bnoordhuis can either of you provide us with a line or two to put in the changelog for this upgrade?

@jbergstroem
Copy link
Member

Seems to cause one new failure on centos5-32/64: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/764/nodes=centos5-32/tapTestReport/test.tap-500/

Edit: same test fails in the same build for smartos32/64 too. I haven't seen this test fail previously (perhaps missed it).

@cjihrig
Copy link
Contributor

cjihrig commented Jun 4, 2015

@jbergstroem the test is new. Looks like it landed in #1855 less than 24 hours ago.

@jbergstroem
Copy link
Member

@cjihrig hm. I'll try backing out the libuv upgrade to see if it still fails.

@cjihrig
Copy link
Contributor

cjihrig commented Jun 4, 2015

Cool. I don't think libuv is the problem though. It doesn't appear that the new test ever went through CI before landing. #1881 and #1885 have already been opened to address problems with it.

@jbergstroem
Copy link
Member

@cjihrig yep, can't reproduce reliably.

@brendanashworth
Copy link
Contributor

@cjihrig @jbergstroem The CI was run (sorry) on #1881. The test should only fail on branches based on bd99e8d...a804026. Rebasing the branch onto HEAD should fix it, with the actual problem behind the test being looked at in #1885.

@saghul
Copy link
Member Author

saghul commented Jun 4, 2015

@rvagg the 2 things that directly affect iojs would be:

  • Fix TTY getting blocked on OSX
  • Fix UDP send callbacks not to be synchronous

@misterdjules
Copy link

@saghul Thank you for nodejs/node-v0.x-archive#25475, it is very much appreciated!

@rvagg rvagg mentioned this pull request Jun 11, 2015
rvagg added a commit that referenced this pull request Jun 13, 2015
Notable Changes:

* libuv: Upgraded to 1.6.0 and 1.6.1, see full ChangeLog for details.
  (Saúl Ibarra Corretgé) #1905 #1889. Highlights include:
  - Fix TTY becoming blocked on OS X
  - Fix UDP send callbacks to not to be synchronous
  - Add uv_os_homedir() (exposed as os.homedir(), see below)
* npm: See full release notes for details. (Kat Marchán) #1899. Highlight:
  - Use GIT_SSH_COMMAND (available as of Git 2.3)
* openssl:
  - Upgrade to 1.0.2b and 1.0.2c, introduces DHE man-in-the-middle protection
    (Logjam) and fixes malformed ECParameters causing infinite loop
    (CVE-2015-1788). See the security advisory for full details.
    (Shigeki Ohtsu) #1950 #1958
  - Support FIPS mode of OpenSSL, see README for instructions.
    (Fedor Indutny) #1890
* os: Add os.homedir() method. (Colin Ihrig) #1791
* smalloc: Deprecate whole module. (Vladimir Kurchatkin) #1822
* Add new collaborators:
  - Alex Kocharin (@rlidwka)
  - Christopher Monsanto (@monsanto)
  - Ali Ijaz Sheikh (@ofrobots)
  - Oleg Elifantiev (@Olegas)
  - Domenic Denicola (@domenic)
  - Rich Trott (@Trott)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants