Commits on Feb 20, 2018

1. src: fix deprecation warning in node_perf.cc …

   Currently the following deprecation warning is produced when compiling
   node_perf.cc:
   
   ./src/node_perf.cc:91:11:
   warning: 'MakeCallback' is deprecated: Use MakeCallback(...,
         async_context) [-Wdeprecated-declarations]
       node::MakeCallback(env->isolate(),
             ^
   ../src/node.h:172:50:
   note: 'MakeCallback' has been explicitly marked deprecated here
                   NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                    ^
   1 warning generated.
   
   This commit adds an async_context to the call and checks the maybe
   result.

   

   danbev committed Feb 20, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 38267bb
   • Browse repository at this point

   Copy the full SHA

   38267bb View commit details

   Browse the repository at this point in the history

2. test: fix deprecation warning in binding.cc …

   Currently, the make-callback-domain-warning addon generates the
   following warning:
   ../binding.cc:22:9:
   warning: 'MakeCallback' is deprecated: Use MakeCallback(...,
         async_context) [-Wdeprecated-declarations]
     node::MakeCallback(isolate, recv, method, 0, nullptr);
           ^
   ../../../../src/node.h:172:50:
   note: 'MakeCallback' has been explicitly marked
         deprecated here
                   NODE_EXTERN v8::Local<v8::Value> MakeCallback(
                                                    ^
   1 warning generated.
   
   This commit fixes this warning.

   

   danbev committed Feb 20, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 69c461f
   • Browse repository at this point

   Copy the full SHA

   69c461f View commit details

   Browse the repository at this point in the history