Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix stack overflow in fs.readdirSync #18647

Closed
wants to merge 1 commit into from
Closed

fs: fix stack overflow in fs.readdirSync #18647

wants to merge 1 commit into from

Commits on Feb 8, 2018

  1. fs: fix stack overflow in fs.readdirSync 

    Previously, fs.readdirSync calls the function returned by
env->push_values_to_array_function() in batch and check the returned
Maybe right away in C++, which can lead to assertions if the call stack
already reaches the maximum size. This patch fixes that by returning
early the call fails so the stack overflow error will be properly
thrown into JS land.
    @joyeecheung
    joyeecheung committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    29faa41 View commit details
    Browse the repository at this point in the history