doc: fix link in https.md #18630
Closed
doc: fix link in https.md #18630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
added
the
fast-track
nodejs-github-bot
added
doc
maclover7
reviewed
Feb 7, 2018
| @@ -257,7 +257,7 @@ const req = https.request(options, (res) => { | |||
| [`http.Server#setTimeout()`]: http.html#http_server_settimeout_msecs_callback | |||
| [`http.Server#timeout`]: http.html#http_server_timeout | |||
| [`http.Server`]: http.html#http_class_http_server | |||
| [`http.createServer()`]: http.html#httpcreateserveroptions-requestlistener | |||
| [`http.createServer()`]: http.html#http_http_createserver_options_requestlistener | |||
There was a problem hiding this comment.
I think this should be http_http_createserver_requestlistener (ex: https://nodejs.org/docs/latest-v6.x/api/http.html#http_http_createserver_requestlistener)
|
Aha - never mind. Looks like the URL hash has changed -- please ignore my review!! LGTM. |
cjihrig
approved these changes
Feb 7, 2018
BridgeAR
approved these changes
Feb 7, 2018
BridgeAR
added
the
author ready
|
Landed in f783d61 |
vsemozhetbyt
added a commit
that referenced
this pull request
Feb 7, 2018
PR-URL: #18630 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18630 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18630 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18630 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18630 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, https
To check:
wrong: https://nodejs.org/download/nightly/v10.0.0-nightly2018020792ba624fa1/docs/api/http.html#httpcreateserveroptions-requestlistener
proper: https://nodejs.org/download/nightly/v10.0.0-nightly2018020792ba624fa1/docs/api/http.html#http_http_createserver_options_requestlistener