tools: add FileHandle to doc/type-parser.js #18601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
vsemozhetbyt
added
the
fs
apapirovski
approved these changes
Feb 6, 2018
vsemozhetbyt
added
the
fast-track
lpinca
approved these changes
Feb 6, 2018
|
Do I understand correctly that CI failure is unrelated? Should we wait till "all green"? |
|
@vsemozhetbyt It is but I would suggest restarting it. Unless that box is down? |
|
@apapirovski I will do, but I already restarted CI here and in another PR, it always fails recently, Maybe something wrong with machines. New CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/156/ |
|
@vsemozhetbyt I pinged @nodejs/build on IRC. Hopefully they can have a look. |
BridgeAR
approved these changes
Feb 6, 2018
BridgeAR
added
the
author ready
|
New green CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/157/ (possible fix: #18605) |
cjihrig
approved these changes
Feb 6, 2018
|
Landed in bff5d5b |
|
With a quick look it appears this only applies to the promise fs apis, if mistaken please change labels and open a backport |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18601 Refs: nodejs#18407 Refs: nodejs#18444 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, fs, tools
Refs: #18407
Refs: #18444