Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-http-parser #18219

Closed
wants to merge 1 commit into from
Closed

test: refactor test-http-parser #18219

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test http

@maclover7
test: refactor test-http-parser
3e67928 
Use common's mustCall (for some reason was implementing its own?), and
other small fixes.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 18, 2018
@maclover7 maclover7 added the http Issues or PRs related to the http subsystem. label Jan 18, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/15501/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 19, 2018
@BridgeAR
Copy link
Member

Landed in 5e17f54

@BridgeAR BridgeAR closed this Jan 19, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 19, 2018
@maclover7 @BridgeAR
test: refactor test-http-parser
5e17f54 
Use common's mustCall (for some reason was implementing its own?), and
other small fixes.

PR-URL: nodejs#18219
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@maclover7 maclover7 deleted the jm-test-http-parser branch January 20, 2018 01:41
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@maclover7 @evanlucas
test: refactor test-http-parser
0b6eab5 
Use common's mustCall (for some reason was implementing its own?), and
other small fixes.

PR-URL: #18219
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@maclover7 @evanlucas
test: refactor test-http-parser
506c6e8 
Use common's mustCall (for some reason was implementing its own?), and
other small fixes.

PR-URL: #18219
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@maclover7 @MylesBorins
test: refactor test-http-parser
9e79951 
Use common's mustCall (for some reason was implementing its own?), and
other small fixes.

PR-URL: #18219
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@maclover7 @MayaLekova
test: refactor test-http-parser
f170af5 
Use common's mustCall (for some reason was implementing its own?), and
other small fixes.

PR-URL: nodejs#18219
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maclover7 @addaleax @BridgeAR @jasnell @lpinca @cjihrig @MylesBorins @nodejs-github-bot